Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1225027

Re: [PATCH v3 2/8] genirq: irqdomain: Remove irqdomain dependency on struct device_node

Show all headers | View raw

On Tue, 15 Sep 2015, Tomasz Nowicki wrote:

Can you folks please do proper quoting on reply? It's annoying to
scroll down 250+ lines to find TWO lines of reply and then have
another 250+ lines for nothing.

Here is the real gist of your reply:

> On 14.09.2015 18:44, Marc Zyngier wrote:
> > -struct irq_domain *__irq_domain_add(struct device_node *of_node, int size,
> > +struct irq_domain *__irq_domain_add(void *domain_token, int size,
> >   				    irq_hw_number_t hwirq_max, int direct_max,
> >   				    const struct irq_domain_ops *ops,
> >   				    void *host_data)
> >   {
> > +	struct device_node *of_node;
> >   	struct irq_domain *domain;
> > 
> > +	of_node = irq_domain_token_to_of_node(domain_token);
> >   	domain = kzalloc_node(sizeof(*domain) + (sizeof(unsigned int) * size),
> >   			      GFP_KERNEL, of_node_to_nid(of_node));
> 
> While we are here, do you think it makes sense to abstract of_node_to_nid as
> well? Then we would really remove device_node dependency for irqdomain.

15 lines of useful content versus 500+ lines of useless noise.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 0/8] Making the generic ACPI GSI layer irqdomain aware Marc Zyngier <marc.zyngier@arm.com> - 2015-09-14 18:50 +0200
  [PATCH v3 5/8] acpi: gsi: Always perform an irq domain lookup Marc Zyngier <marc.zyngier@arm.com> - 2015-09-14 18:50 +0200
  [PATCH v3 8/8] acpi: gsi: Cleanup acpi_register_gsi Marc Zyngier <marc.zyngier@arm.com> - 2015-09-14 18:50 +0200
  [PATCH v3 2/8] genirq: irqdomain: Remove irqdomain dependency on struct device_node Marc Zyngier <marc.zyngier@arm.com> - 2015-09-14 18:50 +0200
    Re: [PATCH v3 2/8] genirq: irqdomain: Remove irqdomain dependency on struct device_node "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-09-15 00:50 +0200
      Re: [PATCH v3 2/8] genirq: irqdomain: Remove irqdomain dependency  on struct device_node Marc Zyngier <marc.zyngier@arm.com> - 2015-09-15 11:20 +0200
        Re: [PATCH v3 2/8] genirq: irqdomain: Remove irqdomain dependency on struct device_node "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-09-16 03:30 +0200
          Re: [PATCH v3 2/8] genirq: irqdomain: Remove irqdomain dependency  on struct device_node Marc Zyngier <marc.zyngier@arm.com> - 2015-09-16 09:50 +0200
            Re: [PATCH v3 2/8] genirq: irqdomain: Remove irqdomain dependency  on struct device_node Thomas Gleixner <tglx@linutronix.de> - 2015-09-16 11:10 +0200
            Re: [PATCH v3 2/8] genirq: irqdomain: Remove irqdomain dependency on struct device_node "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-09-16 14:30 +0200
    Re: [PATCH v3 2/8] genirq: irqdomain: Remove irqdomain dependency on  struct device_node Tomasz Nowicki <tomasz.nowicki@linaro.org> - 2015-09-15 13:00 +0200
      Re: [PATCH v3 2/8] genirq: irqdomain: Remove irqdomain dependency on  struct device_node Tomasz Nowicki <tomasz.nowicki@linaro.org> - 2015-09-15 14:10 +0200
      Re: [PATCH v3 2/8] genirq: irqdomain: Remove irqdomain dependency  on struct device_node Thomas Gleixner <tglx@linutronix.de> - 2015-09-15 14:10 +0200
      Re: [PATCH v3 2/8] genirq: irqdomain: Remove irqdomain dependency  on struct device_node Marc Zyngier <marc.zyngier@arm.com> - 2015-09-15 14:30 +0200

csiph-web