Re: [PATCH 01/13] twl4030_charger: use runtime_pm to keep usb phy active while charging.

From	Pavel Machek <pavel@ucw.cz>
Newsgroups	linux.kernel
Subject	Re: [PATCH 01/13] twl4030_charger: use runtime_pm to keep usb phy active while charging.
Date	2015-09-15 13:30 +0200
Message-ID	<q8WAW-3m7-5@gated-at.bofh.it> (permalink)
References	<pRJTr-7hl-3@gated-at.bofh.it> <pRJTv-7hl-75@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu 2015-07-30 10:11:24, NeilBrown wrote:
> The twl4030 usb phy needs to be active while we are using
> the USB VBUS as a current source for charging.
> In particular, the usb3v1 regulator must be enabled and the
> PHY_PWR_PHYPWD bit must be set to keep the phy powered.
> 
> commit ab37813f4093a5f59cb8e083cde277289dc72ed3
>     twl4030_charger: Allow charger to control the regulator that feeds it
> 
> gave the charger control over the regulator, but didn't resolve
> the PHY_PWR_PHYPWD issue.
> 
> Now that both of these are controlled by runtime_pm in
> phy-twl4030-usb, we can simply take a runtime_pm reference to the USB
> phy whenever the charger wants to use it as a current source.
> 
> So this patch reverts the above commit, and adds the necessary
> runtime_pm calls.
> 
> Acked-by: Lee Jones <lee.jones@linaro.org>
> Signed-off-by: NeilBrown <neil@brown.name>

Acked-by: Pavel Machek <pavel@ucw.cz>

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 01/13] twl4030_charger: use runtime_pm to keep usb phy  active while charging. Pavel Machek <pavel@ucw.cz> - 2015-09-15 13:30 +0200

csiph-web