Re: [PATCH V3 1/3] arm64: dts: Add reset dts config for Hisilicon Hi6220 SoC

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Philipp Zabel <p.zabel@pengutronix.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH V3 1/3] arm64: dts: Add reset dts config for Hisilicon Hi6220 SoC
Date	Tue, 15 Sep 2015 11:30:04 +0200
Message-ID	<q8UIQ-FE-63@gated-at.bofh.it> (permalink)
References	<q8Pzs-1AO-5@gated-at.bofh.it>
X-Original-To	Chen Feng <puck.chen@hisilicon.com>
Content-Type	text/plain; charset="UTF-8"
X-Mailer	Evolution 3.12.9-1+b1
MIME-Version	1.0
Content-Transfer-Encoding	7bit
X-Sa-Exim-Connect-IP	2001:67c:670:100:96de:80ff:fec2:9969
X-Sa-Exim-Mail-From	p.zabel@pengutronix.de
X-Sa-Exim-Scanned	No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false
X-Ptx-Original-Recipient	linux-kernel@vger.kernel.org
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	34
Organization	linux.* mail to news gateway
X-Original-Cc	linux-kernel@vger.kernel.org, robh+dt@kernel.org, pawel.moll@arm.com, xuwei5@hisilicon.com, haojian.zhuang@linaro.org, zhangfei.gao@foxmail.com, arnd@arndb.de, bintian.wang@huawei.com, xuyiping@hisilicon.com, devicetree@vger.kernel.org, dan.zhao@hisilicon.com, suzhuangluan@hisilicon.com, w.f@huawei.com
X-Original-Date	Tue, 15 Sep 2015 11:10:54 +0200
X-Original-Message-ID	<1442308254.3979.31.camel@pengutronix.de>
X-Original-References	<1442289504-183550-1-git-send-email-puck.chen@hisilicon.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1224885

Show key headers only | View raw

Am Dienstag, den 15.09.2015, 11:58 +0800 schrieb Chen Feng:
> Add reset controller for hi6220 hikey-board.
> 
> Signed-off-by: Chen Feng <puck.chen@hisilicon.com>
> ---
>  arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> index 3f03380..3bbc846 100644
> --- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> +++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> @@ -167,5 +167,12 @@
>  			clocks = <&ao_ctrl 36>, <&ao_ctrl 36>;
>  			clock-names = "uartclk", "apb_pclk";
>  		};
> +
> +		reset_ctrl: reset_ctrl@f7030000 {
> +			compatible = "hisilicon,hi6220_reset_ctl";

Check out the other compatible strings that already are in the same dtsi
file, those use hyphens instead of underscores in their compatible
values. So for consistency, this should be:

+			compatible = "hisilicon,hi6220-reset-ctl";

regards
Philipp

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH V3 1/3] arm64: dts: Add reset dts config for Hisilicon Hi6220 SoC Chen Feng <puck.chen@hisilicon.com> - 2015-09-15 06:10 +0200
  Re: [PATCH V3 1/3] arm64: dts: Add reset dts config for Hisilicon  Hi6220 SoC Philipp Zabel <p.zabel@pengutronix.de> - 2015-09-15 11:30 +0200

csiph-web