Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1224730

Re: [PATCH 2.6.32 29/62] sctp: Fix race between OOTB responce and route removal

Show all headers | View raw

On Tue, Sep 15, 2015 at 03:26:44AM +0100, Ben Hutchings wrote:
> On Sun, 2015-09-13 at 00:56 +0200, Willy Tarreau wrote:
> > 2.6.32-longterm review patch.  If anyone has any objections, please let me know.
> > 
> > ------------------
> > 
> > From: Alexander Sverdlin <alexander.sverdlin@nokia.com>
> > 
> > [ Upstream commit 29c4afc4e98f4dc0ea9df22c631841f9c220b944 ]
> > 
> > There is NULL pointer dereference possible during statistics update if the route
> > used for OOTB responce is removed at unfortunate time. If the route exists when
> > we receive OOTB packet and we finally jump into sctp_packet_transmit() to send
> > ABORT, but in the meantime route is removed under our feet, we take "no_route"
> > path and try to update stats with IP_INC_STATS(sock_net(asoc->base.sk), ...).
> [...]
> > [bwh: Backported to 3.2: sctp alway uses init_net]
> > Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> [...]
> 
> This doesn't make sense in 2.6.32 and it didn't make sense for me to
> apply it to 3.2 either!  Since sctp is not using asoc to look up a net
> namespace here, the null pointer doesn't get dereferenced.

Perfect, I'm dropping it now.
Thanks,
Willy

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 2.6.32 29/62] sctp: Fix race between OOTB responce and route removal Willy Tarreau <w@1wt.eu> - 2015-09-13 01:30 +0200
  Re: [PATCH 2.6.32 29/62] sctp: Fix race between OOTB responce and  route removal Ben Hutchings <ben@decadent.org.uk> - 2015-09-15 04:30 +0200
    Re: [PATCH 2.6.32 29/62] sctp: Fix race between OOTB responce and route removal Willy Tarreau <w@1wt.eu> - 2015-09-15 09:50 +0200

csiph-web