Re: [PATCH] cpufreq: cpufreq_cpu_get_raw() isn't a static function anymore

From	Viresh Kumar <viresh.kumar@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] cpufreq: cpufreq_cpu_get_raw() isn't a static function anymore
Date	2015-09-15 10:20 +0200
Message-ID	<q8TD4-7zq-9@gated-at.bofh.it> (permalink)
References	<q8TD4-7zq-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 15-09-15, 13:40, Viresh Kumar wrote:
> Its used outside of the core file and is exported as well. Drop the
> 'static' keyword from its declaration and fix below build error:
> 
> linux/drivers/cpufreq/cpufreq.c:241:31: error: static declaration of
> 'cpufreq_cpu_get_raw' follows non-static declaration
> 
> Fixes: 503655f70d9b ("cpufreq: acpi-cpufreq: Use cpufreq_cpu_get_raw() in ->get()")
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
>  drivers/cpufreq/cpufreq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Urg, sorry for spamming wrong people (Thomas/Alexandra) for an
unrelated patch.

Have sent the relevant patch with this subject now:
"PM / sleep: Fix broken builds without CONFIG_PM_SLEEP_DEBUG"

Though, this fix was also relevant, just sent it to wrong people :(

> diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> index a8252bb0f80c..ef5ed9470de9 100644
> --- a/drivers/cpufreq/cpufreq.c
> +++ b/drivers/cpufreq/cpufreq.c
> @@ -238,7 +238,7 @@ int cpufreq_generic_init(struct cpufreq_policy *policy,
>  }
>  EXPORT_SYMBOL_GPL(cpufreq_generic_init);
>  
> -static struct cpufreq_policy *cpufreq_cpu_get_raw(unsigned int cpu)
> +struct cpufreq_policy *cpufreq_cpu_get_raw(unsigned int cpu)
>  {
>  	struct cpufreq_policy *policy = per_cpu(cpufreq_cpu_data, cpu);
>  
> -- 
> 2.4.0
> 

-- 
viresh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] cpufreq: cpufreq_cpu_get_raw() isn't a static function anymore Viresh Kumar <viresh.kumar@linaro.org> - 2015-09-15 10:20 +0200
  Re: [PATCH] cpufreq: cpufreq_cpu_get_raw() isn't a static function  anymore Viresh Kumar <viresh.kumar@linaro.org> - 2015-09-15 10:20 +0200

csiph-web