Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1224658

Re: [PATCH 2.6.32 18/62] s390/hibernate: fix save and restore of kernel text section

Show all headers | View raw

On Tue, Sep 15, 2015 at 03:10:45AM +0100, Ben Hutchings wrote:
> On Sun, 2015-09-13 at 00:56 +0200, Willy Tarreau wrote:
> > 2.6.32-longterm review patch.  If anyone has any objections, please let me know.
> > 
> > ------------------
> > 
> > From: Heiko Carstens <heiko.carstens@de.ibm.com>
> > 
> > commit d74419495633493c9cd3f2bbeb7f3529d0edded6 upstream.
> > 
> > Sebastian reported a crash caused by a jump label mismatch after resume.
> > This happens because we do not save the kernel text section during suspend
> > and therefore also do not restore it during resume, but use the kernel image
> > that restores the old system.
> [...]
> 
> I don't think this is needed because jump labels aren't implemented in
> 2.6.32.  But maybe there was some other mechanism that changes the
> kernel text on s390?

Broken jump labels were the symptons when the problem was reported. However
we lose everything that modifies kernel text without this patch.
If it's not jump labels then there is still kprobes around where we have
the same problem.
Probably the patch description should have been better.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 2.6.32 18/62] s390/hibernate: fix save and restore of kernel text  section Willy Tarreau <w@1wt.eu> - 2015-09-13 01:30 +0200
  Re: [PATCH 2.6.32 18/62] s390/hibernate: fix save and restore of  kernel text section Ben Hutchings <ben@decadent.org.uk> - 2015-09-15 04:20 +0200
    Re: [PATCH 2.6.32 18/62] s390/hibernate: fix save and restore of  kernel text section Heiko Carstens <heiko.carstens@de.ibm.com> - 2015-09-15 08:10 +0200
      Re: [PATCH 2.6.32 18/62] s390/hibernate: fix save and restore of kernel text section Willy Tarreau <w@1wt.eu> - 2015-09-15 09:50 +0200
        Re: [PATCH 2.6.32 18/62] s390/hibernate: fix save and restore of  kernel text section Heiko Carstens <heiko.carstens@de.ibm.com> - 2015-09-15 09:50 +0200

csiph-web