Re: [PATCH 09/39] aoe: drop null test before destroy functions

From	Ed Cashin <ed.cashin@acm.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 09/39] aoe: drop null test before destroy functions
Date	2015-09-15 03:40 +0200
Message-ID	<q8NnX-6UN-7@gated-at.bofh.it> (permalink)
References	<q8ezT-7xJ-3@gated-at.bofh.it> <q8ezU-7xJ-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

ACK.  Thanks.

On 09/13/2015 08:15 AM, Julia Lawall wrote:
> Remove unneeded NULL test.
>
> The semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@ expression x; @@
> -if (x != NULL)
>    \(kmem_cache_destroy\|mempool_destroy\|dma_pool_destroy\)(x);
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> ---
>   drivers/block/aoe/aoedev.c |    3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/block/aoe/aoedev.c b/drivers/block/aoe/aoedev.c
> index ffd1947..efc8a8a 100644
> --- a/drivers/block/aoe/aoedev.c
> +++ b/drivers/block/aoe/aoedev.c
> @@ -285,8 +285,7 @@ freedev(struct aoedev *d)
>   	e = t + d->ntargets;
>   	for (; t < e && *t; t++)
>   		freetgt(d, *t);
> -	if (d->bufpool)
> -		mempool_destroy(d->bufpool);
> +	mempool_destroy(d->bufpool);
>   	skbpoolfree(d);
>   	minor_free(d->sysminor);
>   
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 09/39] aoe: drop null test before destroy functions Julia Lawall <Julia.Lawall@lip6.fr> - 2015-09-13 14:30 +0200
  Re: [PATCH 09/39] aoe: drop null test before destroy functions Ed Cashin <ed.cashin@acm.org> - 2015-09-15 03:40 +0200

csiph-web