Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1224459

Re: [PATCH] staging: lustre: lnet: lnet: Added a space

Show all headers | View raw

On 09/13/15 06:14, Anjali Menon wrote:
> Added a space to fix the following coding style warning detected by
> checkpatch:

Both your commit title and message say (or imply) you've added a space,
but this patch, in fact, removes a space, doesn't it?

> WARNING: space prohibited between function name and open parenthesis '('
>
> Signed-off-by: Anjali Menon <cse.anjalimenon@gmail.com>
> ---
>  drivers/staging/lustre/lnet/lnet/router.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/lustre/lnet/lnet/router.c b/drivers/staging/lustre/lnet/lnet/router.c
> index 8510bae..be23e06 100644
> --- a/drivers/staging/lustre/lnet/lnet/router.c
> +++ b/drivers/staging/lustre/lnet/lnet/router.c
> @@ -1511,7 +1511,7 @@ lnet_notify(lnet_ni_t *ni, lnet_nid_t nid, int alive, unsigned long when)
>  	unsigned long		now = cfs_time_current();
>  	int			cpt = lnet_cpt_of_nid(nid);
>  
> -	LASSERT(!in_interrupt ());
> +	LASSERT(!in_interrupt());
>  
>  	CDEBUG(D_NET, "%s notifying %s: %s\n",
>  		(ni == NULL) ? "userspace" : libcfs_nid2str(ni->ni_nid),

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] staging: lustre: lnet: lnet: Added a space Anjali Menon <cse.anjalimenon@gmail.com> - 2015-09-13 12:20 +0200
  Re: [PATCH] staging: lustre: lnet: lnet: Added a space Trevor Woerner <twoerner@gmail.com> - 2015-09-14 23:20 +0200
  [PATCH v2] staging: lustre: lnet: lnet: Removed a space Anjali Menon <cse.anjalimenon@gmail.com> - 2015-09-16 13:50 +0200

csiph-web