Re: [RFC PATCH] vfio/pci: Use kernel VPD access functions

From	"Rustad, Mark D" <mark.d.rustad@intel.com>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH] vfio/pci: Use kernel VPD access functions
Date	2015-09-14 23:40 +0200
Message-ID	<q8JDI-1AN-17@gated-at.bofh.it> (permalink)
References	<q7B5w-14M-11@gated-at.bofh.it> <q7HDX-29A-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

> On Sep 11, 2015, at 6:11 PM, Rustad, Mark D <mark.d.rustad@intel.com> wrote:
> 
> Superficially this looks pretty good. I need to think harder to be sure of the details.

This is the first time I've looked at all at any of the vfio code, but this is still looking good to me. Thanks for taking this on and exposing the vfio code to me. I hope more devices will be able to take advantage of the quirk and get their VPD issues resolved.

I did run this on a host with a device with VPD assigned to a guest and did not see any trouble when accessing it concurrently from both the guest and the host on the same and different functions. I don't think my particular environment is ideal to fully reproduce the problem (no writable VPD area), but my initial testing looks good.

Acked-by: Mark Rustad <mark.d.rustad@intel.com>

--
Mark Rustad, Networking Division, Intel Corporation

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RFC PATCH] vfio/pci: Use kernel VPD access functions Alex Williamson <alex.williamson@redhat.com> - 2015-09-11 20:20 +0200
  Re: [RFC PATCH] vfio/pci: Use kernel VPD access functions "Rustad, Mark D" <mark.d.rustad@intel.com> - 2015-09-12 03:20 +0200
    Re: [RFC PATCH] vfio/pci: Use kernel VPD access functions Alex Williamson <alex.williamson@redhat.com> - 2015-09-14 19:00 +0200
    Re: [RFC PATCH] vfio/pci: Use kernel VPD access functions "Rustad, Mark D" <mark.d.rustad@intel.com> - 2015-09-14 23:40 +0200

csiph-web