Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1224350

Re: LTP regressions due to 6dc296e7df4c ("mm: make sure all file VMAs have ->vm_ops set")

Show all headers | View raw

On 09/14, Kirill A. Shutemov wrote:
>
> Fix is below. I don't really like it, but I cannot find any better
> solution.

Me too...

But this change "documents" the nasty special "vm_file && !vm_ops" case, and
I am not sure how we can remove it later...

So perhaps we should change vma_is_anonymous() back to check ->fault too,

	 static inline bool vma_is_anonymous(struct vm_area_struct *vma)
	 {
	-	return !vma->vm_ops;
	+	return !vma->vm_ops || !vma->vm_ops->fault;
	 }

and remove the "vma->vm_file && !vma->vm_ops" checks in mmap_region() paths.

I dunno.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

LTP regressions due to 6dc296e7df4c ("mm: make sure all file VMAs  have ->vm_ops set") Will Deacon <will.deacon@arm.com> - 2015-09-14 13:00 +0200
  RE: LTP regressions due to 6dc296e7df4c ("mm: make sure all file VMAs  have ->vm_ops set") "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> - 2015-09-14 14:00 +0200
    Re: LTP regressions due to 6dc296e7df4c ("mm: make sure all file  VMAs have ->vm_ops set") Will Deacon <will.deacon@arm.com> - 2015-09-14 15:30 +0200
    Re: LTP regressions due to 6dc296e7df4c ("mm: make sure all file  VMAs have ->vm_ops set") Oleg Nesterov <oleg@redhat.com> - 2015-09-14 19:10 +0200
      Re: LTP regressions due to 6dc296e7df4c ("mm: make sure all file  VMAs have ->vm_ops set") Oleg Nesterov <oleg@redhat.com> - 2015-09-14 19:50 +0200
      Re: LTP regressions due to 6dc296e7df4c ("mm: make sure all file  VMAs have ->vm_ops set") "Kirill A. Shutemov" <kirill@shutemov.name> - 2015-09-14 20:30 +0200
        Re: LTP regressions due to 6dc296e7df4c ("mm: make sure all file  VMAs have ->vm_ops set") Oleg Nesterov <oleg@redhat.com> - 2015-09-15 14:20 +0200
          Re: LTP regressions due to 6dc296e7df4c ("mm: make sure all file  VMAs have ->vm_ops set") "Kirill A. Shutemov" <kirill@shutemov.name> - 2015-09-15 15:50 +0200
            Re: LTP regressions due to 6dc296e7df4c ("mm: make sure all file  VMAs have ->vm_ops set") Oleg Nesterov <oleg@redhat.com> - 2015-09-15 17:20 +0200
            Re: LTP regressions due to 6dc296e7df4c  ("mm: make sure all file VMAs have ->vm_ops set") Andrew Morton <akpm@linux-foundation.org> - 2015-09-16 23:30 +0200
              Re: LTP regressions due to 6dc296e7df4c ("mm: make sure all file  VMAs have ->vm_ops set") "Kirill A. Shutemov" <kirill@shutemov.name> - 2015-09-17 17:40 +0200

csiph-web