Re: [RFC PATCH 3/3] devicetree: macb: Add optional property tsu-clk

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Harini Katakam <harinikatakamlinux@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH 3/3] devicetree: macb: Add optional property tsu-clk
Date	Mon, 14 Sep 2015 19:40:02 +0200
Message-ID	<q8FTr-4AL-5@gated-at.bofh.it> (permalink)
References	<q8tfz-3oy-13@gated-at.bofh.it> <q8tfz-3oy-15@gated-at.bofh.it> <q8tfz-3oy-17@gated-at.bofh.it> <q8tfz-3oy-11@gated-at.bofh.it> <q8wQb-8mm-25@gated-at.bofh.it> <q8FTs-4AL-7@gated-at.bofh.it>
X-Original-To	Sören Brinkmann <soren.brinkmann@xilinx.com>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=+NKGRl4vdKK6ONSpriA2SIlNz6fRaEqnHmK/VgKD16I=; b=MaGD5TDEQIrrKHcnwNucQcz2GGVM59x8Yuo3x7K2s1U4SSDHegmvG/3gvOY/jn6YHW /wEoHjelv5lblh/DGJYCAlJceCBiswsK/ESE7hU+9ibPRi36FsQ4xwa5Mnjmx/WjlKUq AMtEU+yrMZlf0tnetx1+JlL/0lrqGyTmU81CW6YvYRtEcyGqso8xIXm8hig3uiMty+tj yeDkbOkbRQV1sIwZ0USULk1Qgdx0122/3s4iF7vuJ6J/gwVwlZzK0W6X4/5QX9+AtuDO mHePPccK7SnWeJdlv8V8xXrPa6QIQugwjEWxAO/dHL9Hfg/hj3pK3bdyGtlmGu6QJORC 8BBg==
MIME-Version	1.0
X-Received	by 10.112.140.232 with SMTP id rj8mr15384975lbb.2.1442252082282; Mon, 14 Sep 2015 10:34:42 -0700 (PDT)
Content-Type	text/plain; charset=UTF-8
Content-Transfer-Encoding	8BIT
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	61
Organization	linux.* mail to news gateway
X-Original-Cc	Boris Brezillon <boris.brezillon@free-electrons.com>, Harini Katakam <harini.katakam@xilinx.com>, Nicolas Ferre <nicolas.ferre@atmel.com>, davem@davemloft.net, Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>, Mark Rutland <mark.rutland@arm.com>, "ijc+devicetree@hellion.org.uk" <ijc+devicetree@hellion.org.uk>, Kumar Gala <galak@codeaurora.org>, alexandre.belloni@free-electrons.com, netdev@vger.kernel.org, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, Punnaiah Choudary Kalluri <punnaia@xilinx.com>, "michals@xilinx.com" <michals@xilinx.com>, anirudh@xilinx.com
X-Original-Date	Mon, 14 Sep 2015 23:04:42 +0530
X-Original-Message-ID	<CAFcVEC+KKhJFW5X2ff5ZY3Tp8LRQ-8=T7X7NJ2bBL7c822KYhw@mail.gmail.com>
X-Original-References	<1441958258-35441-1-git-send-email-harinik@xilinx.com> <1441958258-35441-4-git-send-email-harinik@xilinx.com> <20150911165256.GT19678@xsjsorenbubuntu> <CAFcVECK=EONgqPq1jt_kti-VKXPWGVj3OSnqUvo0YcR65Z+Phg@mail.gmail.com> <20150914095846.0d8e2d74@bbrezillon> <20150914144423.GG19678@xsjsorenbubuntu>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1224363

Show key headers only | View raw

Hi Soren/Boris,

On Mon, Sep 14, 2015 at 8:14 PM, Sören Brinkmann
<soren.brinkmann@xilinx.com> wrote:
> On Mon, 2015-09-14 at 09:58AM +0200, Boris Brezillon wrote:
>> Hi Harini,
>>
>> On Mon, 14 Sep 2015 09:39:05 +0530
>> Harini Katakam <harinikatakamlinux@gmail.com> wrote:
>>
>> > On Fri, Sep 11, 2015 at 10:22 PM, Sören Brinkmann
>> > <soren.brinkmann@xilinx.com> wrote:
>> > > Hi Harini,
>> > >
>> > > On Fri, 2015-09-11 at 01:27PM +0530, Harini Katakam wrote:
>> > >> Add TSU clock frequency to be used for 1588 support in macb driver.
>> > >>
>> > >> Signed-off-by: Harini Katakam <harinik@xilinx.com>
>> > >> ---
>> > >>  Documentation/devicetree/bindings/net/macb.txt |    3 +++
>> > >>  1 file changed, 3 insertions(+)
>> > >>
>> > >> diff --git a/Documentation/devicetree/bindings/net/macb.txt b/Documentation/devicetree/bindings/net/macb.txt
>> > >> index b5d7976..f7c0ea8 100644
>> > >> --- a/Documentation/devicetree/bindings/net/macb.txt
>> > >> +++ b/Documentation/devicetree/bindings/net/macb.txt
>> > >> @@ -19,6 +19,9 @@ Required properties:
>> > >>       Optional elements: 'tx_clk'
>> > >>  - clocks: Phandles to input clocks.
>> > >>
>> > >> +Optional properties:
>> > >> +- tsu-clk: Time stamp unit clock frequency used.
>> > >
>> > > Why are we not using the CCF and a clk_get_rate() in the driver?
>> > >
>> >
>> > If the clock source was only internal, we could use this
>> > approach as usual. But TSU clock can be configured to
>> > come from an external clock source or internal.
>>
>> How about declaring a fixed-rate clk [1] if it comes from an external
>> clk, and using a clk driver for the internal clk case?
>> This way you'll be able to use the clk API (including the
>> clk_get_rate() function) instead of introducing a new way to retrieve a
>> clk frequency.
>
> Right. Also, Zynq does already support external clock inputs (actually,
> every clock originates from some external clock/oscillator at some
> point). Maybe that code needs some additions to handle the TSU clock
> too. But either way, I can't see why a clock cannot be modeled using the
> CCF.

Ok, I'm going to try this.

Regards,
Harini
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [RFC PATCH 3/3] devicetree: macb: Add optional property tsu-clk Harini Katakam <harinikatakamlinux@gmail.com> - 2015-09-14 06:10 +0200
  Re: [RFC PATCH 3/3] devicetree: macb: Add optional property tsu-clk Boris Brezillon <boris.brezillon@free-electrons.com> - 2015-09-14 10:00 +0200
    Re: [RFC PATCH 3/3] devicetree: macb: Add optional property tsu-clk Harini Katakam <harinikatakamlinux@gmail.com> - 2015-09-14 19:40 +0200

csiph-web