Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1222885

[PATCH 2/2] clk: at91: system: don't try to free_irq when there is no IRQ

Show all headers | View raw

In the error path of at91_clk_register_system(), sys->irq is freed
unconditionally but it may not exist or be request at all.

Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
---
 drivers/clk/at91/clk-system.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/clk/at91/clk-system.c b/drivers/clk/at91/clk-system.c
index 58008b3e8bc1..3f5314344286 100644
--- a/drivers/clk/at91/clk-system.c
+++ b/drivers/clk/at91/clk-system.c
@@ -138,7 +138,8 @@ at91_clk_register_system(struct at91_pmc *pmc, const char *name,
 
 	clk = clk_register(NULL, &sys->hw);
 	if (IS_ERR(clk)) {
-		free_irq(sys->irq, sys);
+		if (irq)
+			free_irq(sys->irq, sys);
 		kfree(sys);
 	}
 
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 2/2] clk: at91: system: don't try to free_irq when there is no IRQ Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2015-09-11 16:40 +0200
  Re: [PATCH 2/2] clk: at91: system: don't try to free_irq when there  is no IRQ Boris Brezillon <boris.brezillon@free-electrons.com> - 2015-09-14 16:50 +0200
  Re: [PATCH 2/2] clk: at91: system: don't try to free_irq when there  is no IRQ Stephen Boyd <sboyd@codeaurora.org> - 2015-09-15 00:00 +0200

csiph-web