[PATCH 04/16] PM / OPP: Rename routines specific to old bindings with _v1

Path	csiph.com!goblin1!goblin2!goblin.stu.neva.ru!gothmog.csi.it!bofh.it!news.nic.it!robomod
From	Viresh Kumar <viresh.kumar@linaro.org>
Newsgroups	linux.kernel
Subject	[PATCH 04/16] PM / OPP: Rename routines specific to old bindings with _v1
Date	Fri, 11 Sep 2015 14:10:02 +0200
Message-ID	<q7vjs-15e-29@gated-at.bofh.it> (permalink)
References	<q7vjr-15e-3@gated-at.bofh.it>
X-Original-To	Rafael Wysocki <rjw@rjwysocki.net>, nm@ti.com, sboyd@codeaurora.org
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=4+b+UI1Cy/qeC4VmiqH1qPE0kZH0Ha22af7/qKFgqhA=; b=c7GLEi6s7ww5nsoCQ4bGmZgCIvqLtO8G05K0aNriiDaiU2+avlTAvdPdoypf2alof7 Cl+vqA4q9e+ujbgiBQrbT9cvT9ocKhd49KOS4GAiOUoRxbTir2/ZPTk9NMmvUdXOn6qn 9R+93wHQUtu6LaJ1mqSJaMOf3sXU0Zt2StH0KvrNnFqzDcMwVEt+qRoC548QdeNoRzlA syeIjkC/yjwolQ4/zLppeYP4ElZRi+k/WtnbMIayKr+mO6zEpfPVBaz3UhTSLCTxU0nS Pd8xCvFayyQcUgTNZhlBNpdg8NAKPJfvNfbG1wyu6J/mFTo7tJwXYIHyGkPagwCGtvPN gB5w==
X-Gm-Message-State	ALoCoQkhvkNODShwGPeJh9W8hTXjMnKwKvaxoAkjJ83T2EpSHVF/QBGeskv8nV2MXEDCNIlofqJh
X-Received	by 10.67.4.230 with SMTP id ch6mr22896922pad.11.1441972966023; Fri, 11 Sep 2015 05:02:46 -0700 (PDT)
X-Mailer	git-send-email 2.4.0
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	59
Organization	linux.* mail to news gateway
X-Original-Cc	linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org, rob.herring@linaro.org, lee.jones@linaro.org, Viresh Kumar <viresh.kumar@linaro.org>, Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>, Dmitry Torokhov <dtor@chromium.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Len Brown <len.brown@intel.com>, linux-kernel@vger.kernel.org (open list), Pavel Machek <pavel@ucw.cz>
X-Original-Date	Fri, 11 Sep 2015 17:32:00 +0530
X-Original-Message-ID	<eadf49f87f771f65292c393c455a457a2f976a65.1441972771.git.viresh.kumar@linaro.org>
X-Original-References	<cover.1441972771.git.viresh.kumar@linaro.org>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1222762

Show key headers only | View raw

Clearly distinguish routines based on what version of bindings they
parse. We have already postfixed routines properly with _v2 for new
bindings. Postfix the older ones now with _v1.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
 drivers/base/power/opp/core.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/base/power/opp/core.c b/drivers/base/power/opp/core.c
index 113fdd0ce6d9..6bebc503d727 100644
--- a/drivers/base/power/opp/core.c
+++ b/drivers/base/power/opp/core.c
@@ -718,7 +718,7 @@ static int _opp_add(struct device *dev, struct dev_pm_opp *new_opp,
 }
 
 /**
- * _opp_add_dynamic() - Allocate a dynamic OPP.
+ * _opp_add_v1() - Allocate a OPP based on v1 bindings.
  * @dev:	device for which we do this operation
  * @freq:	Frequency in Hz for this OPP
  * @u_volt:	Voltage in uVolts for this OPP
@@ -744,8 +744,8 @@ static int _opp_add(struct device *dev, struct dev_pm_opp *new_opp,
  *		Duplicate OPPs (both freq and volt are same) and !opp->available
  * -ENOMEM	Memory allocation failure
  */
-static int _opp_add_dynamic(struct device *dev, unsigned long freq,
-			    long u_volt, bool dynamic)
+static int _opp_add_v1(struct device *dev, unsigned long freq, long u_volt,
+		       bool dynamic)
 {
 	struct device_opp *dev_opp;
 	struct dev_pm_opp *new_opp;
@@ -949,7 +949,7 @@ static int _opp_add_static_v2(struct device *dev, struct device_node *np)
  */
 int dev_pm_opp_add(struct device *dev, unsigned long freq, unsigned long u_volt)
 {
-	return _opp_add_dynamic(dev, freq, u_volt, true);
+	return _opp_add_v1(dev, freq, u_volt, true);
 }
 EXPORT_SYMBOL_GPL(dev_pm_opp_add);
 
@@ -1251,7 +1251,7 @@ static int _of_add_opp_table_v1(struct device *dev)
 		unsigned long freq = be32_to_cpup(val++) * 1000;
 		unsigned long volt = be32_to_cpup(val++);
 
-		if (_opp_add_dynamic(dev, freq, volt, false))
+		if (_opp_add_v1(dev, freq, volt, false))
 			dev_warn(dev, "%s: Failed to add OPP %ld\n",
 				 __func__, freq);
 		nr -= 2;
-- 
2.4.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH 04/16] PM / OPP: Rename routines specific to old bindings with _v1 Viresh Kumar <viresh.kumar@linaro.org> - 2015-09-11 14:10 +0200

csiph-web