Re: cpufreq: mediatek: allow modular build

From	Russell King - ARM Linux <linux@arm.linux.org.uk>
Newsgroups	linux.kernel
Subject	Re: cpufreq: mediatek: allow modular build
Date	2015-09-11 12:00 +0200
Message-ID	<q7thE-6pR-23@gated-at.bofh.it> (permalink)
References	(2 earlier) <q7rSx-4w9-5@gated-at.bofh.it> <q7s2e-4Hu-17@gated-at.bofh.it> <q7s2e-4Hu-15@gated-at.bofh.it> <q7sYi-63o-15@gated-at.bofh.it> <q7t7Y-6eG-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Sep 11, 2015 at 03:10:03PM +0530, Viresh Kumar wrote:
> On 11-09-15, 10:34, Russell King - ARM Linux wrote:
> > Well, that's got nothing to do with not having a module_exit().
> 
> Yeah, so we don't necessarily need a module_exit(), but the module
> should have freed the resources with module unplug. And that was
> missing with Arnd's patch..

Not module "unplug" (I've never heard it called that before).  A module
with a module_init() but no module_exit() can only be added to a running
kernel, and never removed.  That's intentional behaviour.

However, if you're talking about hot-unplug, presumably you're talking
about _CPU_ hot-unplug, and that's something the code should definitely
handle irrespective of whether it's built-in or a module.

The two issues are entirely separate.

-- 
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

cpufreq: mediatek: allow modular build Arnd Bergmann <arnd@arndb.de> - 2015-09-11 10:20 +0200
  Re: cpufreq: mediatek: allow modular build Viresh Kumar <viresh.kumar@linaro.org> - 2015-09-11 10:20 +0200
    Re: cpufreq: mediatek: allow modular build Viresh Kumar <viresh.kumar@linaro.org> - 2015-09-11 10:30 +0200
      Re: cpufreq: mediatek: allow modular build Arnd Bergmann <arnd@arndb.de> - 2015-09-11 10:40 +0200
        Re: cpufreq: mediatek: allow modular build Viresh Kumar <viresh.kumar@linaro.org> - 2015-09-11 10:40 +0200
          Re: cpufreq: mediatek: allow modular build Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-09-11 11:40 +0200
            Re: cpufreq: mediatek: allow modular build Viresh Kumar <viresh.kumar@linaro.org> - 2015-09-11 11:50 +0200
              Re: cpufreq: mediatek: allow modular build Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-09-11 12:00 +0200
                Re: cpufreq: mediatek: allow modular build Viresh Kumar <viresh.kumar@linaro.org> - 2015-09-11 12:10 +0200
                Re: cpufreq: mediatek: allow modular build Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-09-11 12:20 +0200
                Re: cpufreq: mediatek: allow modular build Viresh Kumar <viresh.kumar@linaro.org> - 2015-09-11 12:20 +0200
    Re: cpufreq: mediatek: allow modular build Arnd Bergmann <arnd@arndb.de> - 2015-09-11 10:30 +0200

csiph-web