Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1222599

Re: [PATCH 6/6] mfd: arizona: Update DT binding documentation for jack detection

Show all headers | View raw

On 2015년 09월 10일 20:41, Charles Keepax wrote:
> Add additional bindings for both inverting the polarity of the jack
> detection pins and allowing the use of a second jack detection pin. Note
> that the second jack detection pin is hard wired in the chip so can only
> be enabled through the binding, rather than a pin being specified.
> 
> Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
> ---
>  Documentation/devicetree/bindings/mfd/arizona.txt |    6 ++++++
>  1 files changed, 6 insertions(+), 0 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/arizona.txt b/Documentation/devicetree/bindings/mfd/arizona.txt
> index b98a11b..48bca6a 100644
> --- a/Documentation/devicetree/bindings/mfd/arizona.txt
> +++ b/Documentation/devicetree/bindings/mfd/arizona.txt
> @@ -73,6 +73,12 @@ Optional properties:
>      If this node is not mentioned or if the value is unknown, then
>      headphone detection mode is set to HPDETL.
>  
> +  - wlf,use-jd-gpio : Use GPIO input alongwith JD1 for dual pin jack

s/alongwith/along with

> +    detection.
> +  - wlf,use-jd-gpio-nopull : Internal pull on GPIO is disabled when used for
> +    jack detection.
> +  - wlf,jd-invert : Invert the polarity of the jack detection switch
> +
>    - wlf,micd-software-compare : Use a software comparison to determine mic
>      presence
>    - wlf,micd-detect-debounce : Additional software microphone detection
> 

If you fixes the minor typo, looks good to me.
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>

Thanks,
Chanwoo Choi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/6] mfd: arizona: Add TST_CAP bits for headphone detection Charles Keepax <ckeepax@opensource.wolfsonmicro.com> - 2015-09-10 14:10 +0200
  [PATCH 2/6] extcon: arizona: Additional settings to improve accuracy of HP detect Charles Keepax <ckeepax@opensource.wolfsonmicro.com> - 2015-09-10 14:10 +0200
    Re: [PATCH 2/6] extcon: arizona: Additional settings to improve  accuracy of HP detect Chanwoo Choi <cw00.choi@samsung.com> - 2015-09-11 10:20 +0200
  [PATCH 6/6] mfd: arizona: Update DT binding documentation for jack detection Charles Keepax <ckeepax@opensource.wolfsonmicro.com> - 2015-09-10 14:10 +0200
    Re: [PATCH 6/6] mfd: arizona: Update DT binding documentation for jack  detection Chanwoo Choi <cw00.choi@samsung.com> - 2015-09-11 10:10 +0200
  [PATCH 3/6] extcon: arizona: Ignore jd_invert for MICD_CLAMP_STS Charles Keepax <ckeepax@opensource.wolfsonmicro.com> - 2015-09-10 14:10 +0200
    Re: [PATCH 3/6] extcon: arizona: Ignore jd_invert for MICD_CLAMP_STS Chanwoo Choi <cw00.choi@samsung.com> - 2015-09-11 10:10 +0200
  Re: [PATCH 1/6] mfd: arizona: Add TST_CAP bits for headphone detection Chanwoo Choi <cw00.choi@samsung.com> - 2015-09-11 10:20 +0200

csiph-web