[PATCHv2 00/16] staging: rtl8192u: code clean up

From	Raphaël Beamonte <raphael.beamonte@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCHv2 00/16] staging: rtl8192u: code clean up
Date	2015-09-11 09:40 +0200
Message-ID	<q7r69-3lW-3@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi,

Following comments from Dan Carpenter on my previous patch to
limit the lines lengths for rtl8192u/r8192U_core.c [1], please
find attached a set of patches splitting those operations.

I also took care of keeping the code the more readable possible,
some of those patchs even aim to clean the original content.

The last patch gets rid of the last WARNING of checkpatch about
the 80 lines, as well as the TO_DO_LIST macro that was used in
that module to comment out unused or unusable code.

Thanks,
- R.

[1]: https://lkml.org/lkml/2015/8/19/173


Raphaël Beamonte (16):
  staging: rtl8192u: r8192U_core: fix comments lines over 80 characters
  staging: rtl8192u: r8192U_core: add line breaks to keep lines under 80
    characters
  staging: rtl8192u: r8192U_core: add temporary variables to keep lines
    under 80 characters
  staging: rtl8192u: r8192U_core: reverse conditions to get lines under
    80 characters
  staging: rtl8192u: r8192U_core: rtl8192_adapter_start: reorganize
    function
  staging: rtl8192u: r8192U_core: rtl8192_read_eeprom_info: reorganize
    function
  staging: rtl8192u: r8192U_core: rtl8192_process_phyinfo: rename
    variable pprevious_stats to prev_stats
  staging: rtl8192u: r8192U_core: rtl8192_process_phyinfo: rename
    variable slide_beacon_adc_pwdb_index to sb_index
  staging: rtl8192u: r8192U_core: rtl8192_process_phyinfo: rename
    variable slide_beacon_adc_pwdb_statistics to sb_stats
  staging: rtl8192u: r8192U_core: rtl8192_process_phyinfo: remove
    unneeded variable
  staging: rtl8192u: r8192U_core: rtl8192_process_phyinfo: rename
    variable rfpath to rfp
  staging: rtl8192u: r8192U_core: rtl8192_process_phyinfo: reorganize
    function
  staging: rtl8192u: r8192U_core: rtl8192_tx: replace some inline
    conditions
  staging: rtl8192u: r8192U_core: rtl8192_ioctl: reorganize function
  staging: rtl8192u: r8192U_core: replace else { if() {} } by else if ()
    {}
  staging: rtl8192u: remove all code framed by symbol TO_DO_LIST

 drivers/staging/rtl8192u/ieee80211/ieee80211.h     |    4 +-
 drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c  |   23 -
 .../staging/rtl8192u/ieee80211/rtl819x_HTProc.c    |    4 -
 .../staging/rtl8192u/ieee80211/rtl819x_TSProc.c    |    5 +-
 drivers/staging/rtl8192u/r8192U_core.c             | 1548 ++++++++++++--------
 drivers/staging/rtl8192u/r819xU_phy.c              |   57 -
 6 files changed, 940 insertions(+), 701 deletions(-)

-- 
2.5.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCHv2 00/16] staging: rtl8192u: code clean up Raphaël Beamonte <raphael.beamonte@gmail.com> - 2015-09-11 09:40 +0200
  [PATCHv2 01/16] staging: rtl8192u: r8192U_core: fix comments lines over 80 characters Raphaël Beamonte <raphael.beamonte@gmail.com> - 2015-09-11 09:40 +0200
  [PATCHv2 10/16] staging: rtl8192u: r8192U_core: rtl8192_process_phyinfo: remove unneeded variable Raphaël Beamonte <raphael.beamonte@gmail.com> - 2015-09-11 09:40 +0200
  [PATCHv2 11/16] staging: rtl8192u: r8192U_core: rtl8192_process_phyinfo: rename variable rfpath to rfp Raphaël Beamonte <raphael.beamonte@gmail.com> - 2015-09-11 09:40 +0200
  [PATCHv2 15/16] staging: rtl8192u: r8192U_core: replace else { if() {} } by else if () {} Raphaël Beamonte <raphael.beamonte@gmail.com> - 2015-09-11 09:40 +0200
  [PATCHv2 07/16] staging: rtl8192u: r8192U_core: rtl8192_process_phyinfo: rename variable pprevious_stats to prev_stats Raphaël Beamonte <raphael.beamonte@gmail.com> - 2015-09-11 09:40 +0200
  [PATCHv2 06/16] staging: rtl8192u: r8192U_core: rtl8192_read_eeprom_info: reorganize function Raphaël Beamonte <raphael.beamonte@gmail.com> - 2015-09-11 09:40 +0200
  [PATCHv2 13/16] staging: rtl8192u: r8192U_core: rtl8192_tx: replace some inline conditions Raphaël Beamonte <raphael.beamonte@gmail.com> - 2015-09-11 09:40 +0200
  [PATCHv2 03/16] staging: rtl8192u: r8192U_core: add temporary variables to keep lines under 80 characters Raphaël Beamonte <raphael.beamonte@gmail.com> - 2015-09-11 09:40 +0200
    Re: [PATCHv2 03/16] staging: rtl8192u: r8192U_core: add temporary  variables to keep lines under 80 characters Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2015-09-17 07:00 +0200
      Re: [PATCHv2 03/16] staging: rtl8192u: r8192U_core: add temporary  variables to keep lines under 80 characters Raphaël Beamonte <raphael.beamonte@gmail.com> - 2015-09-17 07:10 +0200
        Re: [PATCHv2 03/16] staging: rtl8192u: r8192U_core: add temporary  variables to keep lines under 80 characters Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2015-09-17 07:20 +0200
          Re: [PATCHv2 03/16] staging: rtl8192u: r8192U_core: add temporary  variables to keep lines under 80 characters Raphaël Beamonte <raphael.beamonte@gmail.com> - 2015-09-17 20:30 +0200
  [PATCHv2 12/16] staging: rtl8192u: r8192U_core: rtl8192_process_phyinfo: reorganize function Raphaël Beamonte <raphael.beamonte@gmail.com> - 2015-09-11 09:40 +0200
  [PATCHv2 08/16] staging: rtl8192u: r8192U_core: rtl8192_process_phyinfo: rename variable slide_beacon_adc_pwdb_index to sb_index Raphaël Beamonte <raphael.beamonte@gmail.com> - 2015-09-11 09:40 +0200
  [PATCHv2 05/16] staging: rtl8192u: r8192U_core: rtl8192_adapter_start: reorganize function Raphaël Beamonte <raphael.beamonte@gmail.com> - 2015-09-11 09:40 +0200
  [PATCHv2 04/16] staging: rtl8192u: r8192U_core: reverse conditions to get lines under 80 characters Raphaël Beamonte <raphael.beamonte@gmail.com> - 2015-09-11 09:40 +0200
  Re: [PATCHv2 02/16] staging: rtl8192u: r8192U_core: add line breaks  to keep lines under 80 characters Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2015-09-17 07:00 +0200
  [PATCHv3 00/15] staging: rtl8192u: code clean up Raphaël Beamonte <raphael.beamonte@gmail.com> - 2015-09-20 19:20 +0200
    [PATCHv3 11/15] staging: rtl8192u: r8192U_core: rtl8192_process_phyinfo: reorganize function Raphaël Beamonte <raphael.beamonte@gmail.com> - 2015-09-20 19:20 +0200
    [PATCHv3 06/15] staging: rtl8192u: r8192U_core: rtl8192_process_phyinfo: rename variable pprevious_stats to prev_stats Raphaël Beamonte <raphael.beamonte@gmail.com> - 2015-09-20 19:20 +0200
    [PATCHv3 04/15] staging: rtl8192u: r8192U_core: rtl8192_adapter_start: reorganize function Raphaël Beamonte <raphael.beamonte@gmail.com> - 2015-09-20 19:20 +0200
    [PATCHv3 13/15] staging: rtl8192u: r8192U_core: rtl8192_ioctl: reorganize function Raphaël Beamonte <raphael.beamonte@gmail.com> - 2015-09-20 19:20 +0200
    [PATCHv3 05/15] staging: rtl8192u: r8192U_core: rtl8192_read_eeprom_info: reorganize function Raphaël Beamonte <raphael.beamonte@gmail.com> - 2015-09-20 19:20 +0200
    [PATCHv3 10/15] staging: rtl8192u: r8192U_core: rtl8192_process_phyinfo: rename variable rfpath to rfp Raphaël Beamonte <raphael.beamonte@gmail.com> - 2015-09-20 19:20 +0200
    [PATCHv3 07/15] staging: rtl8192u: r8192U_core: rtl8192_process_phyinfo: rename variable slide_beacon_adc_pwdb_index to sb_index Raphaël Beamonte <raphael.beamonte@gmail.com> - 2015-09-20 19:20 +0200
    [PATCHv3 14/15] staging: rtl8192u: r8192U_core: replace else { if() {} } by else if () {} Raphaël Beamonte <raphael.beamonte@gmail.com> - 2015-09-20 19:20 +0200
    [PATCHv3 15/15] staging: rtl8192u: remove all code framed by symbol TO_DO_LIST Raphaël Beamonte <raphael.beamonte@gmail.com> - 2015-09-20 19:20 +0200
    [PATCHv3 09/15] staging: rtl8192u: r8192U_core: rtl8192_process_phyinfo: remove unneeded variable Raphaël Beamonte <raphael.beamonte@gmail.com> - 2015-09-20 19:30 +0200
    [PATCHv3 08/15] staging: rtl8192u: r8192U_core: rtl8192_process_phyinfo: rename variable slide_beacon_adc_pwdb_statistics to sb_stats Raphaël Beamonte <raphael.beamonte@gmail.com> - 2015-09-20 19:30 +0200
    [PATCHv3 02/15] staging: rtl8192u: r8192U_core: add temporary variables to keep lines under 80 characters Raphaël Beamonte <raphael.beamonte@gmail.com> - 2015-09-20 19:30 +0200
      Re: [PATCHv3 02/15] staging: rtl8192u: r8192U_core: add temporary  variables to keep lines under 80 characters Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2015-09-21 06:40 +0200
        Re: [PATCHv3 02/15] staging: rtl8192u: r8192U_core: add temporary  variables to keep lines under 80 characters Raphaël Beamonte <raphael.beamonte@gmail.com> - 2015-09-21 18:40 +0200
    [PATCHv3 03/15] staging: rtl8192u: r8192U_core: reverse conditions to get lines under 80 characters Raphaël Beamonte <raphael.beamonte@gmail.com> - 2015-09-20 19:30 +0200

csiph-web