Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1222369

Re: [PATCH 96/98] HACK include/uapi/linux/coda_psdev.h: fix compilation in userspace

Show all headers | View raw

On Sun, May 31, 2015 at 07:19:13AM -0400, Jan Harkes wrote:
> On Sat, May 30, 2015 at 05:39:28PM +0200, Mikko Rapeli wrote:
> > Include linux/coda.h for caddr_t and use unsigned short type directly.
> > Userspace headers do not have list_head and wait_queue_head_t so just
> > ifdef them away which is a HACK. Any ideas how to fix this properly?
> 
> I grepped the Coda userspace sources and it doesn't look like this
> particular struct is used there anyway, it is only used by the kernel
> module to track which requests are waiting to be read by the Coda
> userspace application and after that which requests are waiting for a
> response.
> 
> I guess a proper fix would be to move this struct to a non-uapi header,
> or maybe even to the (probably) only C file in the kernel where it is
> used.

Thanks! I'm moving upc_req definition to kernel side linux/coda_psdev.h
in the next version of the patches.

-Mikko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 96/98] HACK include/uapi/linux/coda_psdev.h: fix  compilation in userspace Mikko Rapeli <mikko.rapeli@iki.fi> - 2015-09-10 21:50 +0200

csiph-web