Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1222244

Re: [Linux v4.2] workqueue: llvmlinux: acpid: BUG: sleeping function called from invalid context at kernel/workqueue.c:2680

From Tejun Heo <tj@kernel.org>
Newsgroups linux.kernel
Subject Re: [Linux v4.2] workqueue: llvmlinux: acpid: BUG: sleeping function called from invalid context at kernel/workqueue.c:2680
Date 2015-09-10 17:00 +0200
Message-ID <q7buq-4DO-3@gated-at.bofh.it> (permalink)
References <q6KNB-i6-43@gated-at.bofh.it> <q6Yxb-3aF-1@gated-at.bofh.it> <q7buq-4DO-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Thu, Sep 10, 2015 at 10:52:27AM -0400, Tejun Heo wrote:
> Hey,
> 
> On Thu, Sep 10, 2015 at 09:04:27AM +0800, Lai Jiangshan wrote:
> > I think we need to add might_sleep() on the top of __cancel_work_timer().
> > The might_sleep() on the start_flush_work() doesn't cover all the
> > paths of __cancel_work_timer().
> > And it can help to narrow the area of this bug.
> 
> Sure, can you submit a patch?

That said, this one is likely not a bug in the kernel code but more
likely llvm either miscompiling or deviating from gcc behavior on some
corner cases.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [Linux v4.2] workqueue: llvmlinux: acpid: BUG: sleeping function  called from invalid context at kernel/workqueue.c:2680 Lai Jiangshan <jiangshanlai@gmail.com> - 2015-09-10 03:10 +0200
  Re: [Linux v4.2] workqueue: llvmlinux: acpid: BUG: sleeping function  called from invalid context at kernel/workqueue.c:2680 Tejun Heo <tj@kernel.org> - 2015-09-10 17:00 +0200
    Re: [Linux v4.2] workqueue: llvmlinux: acpid: BUG: sleeping function  called from invalid context at kernel/workqueue.c:2680 Sedat Dilek <sedat.dilek@gmail.com> - 2015-09-11 18:20 +0200
      Re: [Linux v4.2] workqueue: llvmlinux: acpid: BUG: sleeping function  called from invalid context at kernel/workqueue.c:2680 Sedat Dilek <sedat.dilek@gmail.com> - 2015-09-14 13:50 +0200
  Re: [Linux v4.2] workqueue: llvmlinux: acpid: BUG: sleeping function  called from invalid context at kernel/workqueue.c:2680 Tejun Heo <tj@kernel.org> - 2015-09-10 17:00 +0200

csiph-web