Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1222225

Re: [Linaro-acpi] [PATCH v3 1/5] ACPI: add in a bad_madt_entry() function to eventually replace the macro

Show all headers | View raw

On 09/10/2015 06:14 AM, Graeme Gregory wrote:
> On Wed, Sep 09, 2015 at 03:09:47PM -0600, Al Stone wrote:
>> The existing BAD_MADT_ENTRY macro only checks that the size of the data
>> structure for an MADT subtable matches the length entry in the subtable.
>> This is, unfortunately, not reliable.  Nor, as it turns out, does it have
>> anything to do with what the length should be in any particular table.
>>

[snip...]
  			if (handler(entry, table_end))
>>  				return -EINVAL;
>>  
>> @@ -349,7 +592,7 @@ int __init acpi_table_parse(char *id, acpi_tbl_table_handler handler)
>>  		return -ENODEV;
>>  }
>>  
>> -/* 
>> +/*
>>   * The BIOS is supposed to supply a single APIC/MADT,
>>   * but some report two.  Provide a knob to use either.
>>   * (don't you wish instance 0 and 1 were not the same?)
> 
> Unrelated whitespace change snuck in here.
> 
> Graeme

Bah.  Nice catch; not sure how that got in there, but duly noted.

-- 
ciao,
al
-----------------------------------
Al Stone
Software Engineer
Red Hat, Inc.
ahs3@redhat.com
-----------------------------------
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v3 1/5] ACPI: add in a bad_madt_entry() function to eventually replace the macro Al Stone <al.stone@linaro.org> - 2015-09-09 23:20 +0200
  Re: [Linaro-acpi] [PATCH v3 1/5] ACPI: add in a bad_madt_entry()  function to eventually replace the macro Graeme Gregory <graeme.gregory@linaro.org> - 2015-09-10 14:20 +0200
    Re: [Linaro-acpi] [PATCH v3 1/5] ACPI: add in a bad_madt_entry()  function to eventually replace the macro Al Stone <ahs3@redhat.com> - 2015-09-10 16:20 +0200

csiph-web