Re: [PATCH 1/5] virtio-gpu: add virtio_gpu_queue_ctrl_buffer_nolock

From	Gerd Hoffmann <kraxel@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/5] virtio-gpu: add virtio_gpu_queue_ctrl_buffer_nolock
Date	2015-09-10 16:10 +0200
Message-ID	<q7aI2-3GV-17@gated-at.bofh.it> (permalink)
References	<q6M2Z-1ZO-3@gated-at.bofh.it> <q6M2Z-1ZO-1@gated-at.bofh.it> <q75In-4L3-59@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Do, 2015-09-10 at 09:39 +0100, Emil Velikov wrote:
> Hi Gerd,
> 
> On 9 September 2015 at 12:42, Gerd Hoffmann <kraxel@redhat.com> wrote:
> > Add virtio_gpu_queue_ctrl_buffer_nolock function, which does the same as
> > virtio_gpu_queue_ctrl_buffer but does not take the virtqueue lock.  The
> > caller must hold the lock instead.
> >
> The drm subsystem tends to use *_locked and *_unlocked suffixes. With
> the latter being less common.
> Not a big deal but perhaps you can use one of those for virtio ?

_locked looks correct for this case to me (looking at drm_vm_close +
drm_vm_close_locked to compare).  I'll change it.

cheers,
  Gerd


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/5] virtio-gpu: add virtio_gpu_queue_ctrl_buffer_nolock Gerd Hoffmann <kraxel@redhat.com> - 2015-09-09 13:50 +0200
  Re: [PATCH 1/5] virtio-gpu: add virtio_gpu_queue_ctrl_buffer_nolock Emil Velikov <emil.l.velikov@gmail.com> - 2015-09-10 10:50 +0200
    Re: [PATCH 1/5] virtio-gpu: add virtio_gpu_queue_ctrl_buffer_nolock Gerd Hoffmann <kraxel@redhat.com> - 2015-09-10 16:10 +0200

csiph-web