Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1223421

Re: [PATCH 4/6] Staging: iio: cdc: Prefer using the BIT macro

Show all headers | View raw

On Sat, Sep 12, 2015 at 04:47:23PM +0530, Shraddha Barke wrote:
> 
> 
> On Sat, Sep 12, 2015 at 3:17 PM, Jonathan Cameron <jic23@kernel.org> wrote:
> 
>     On 10/09/15 17:32, Shraddha Barke wrote:
>     > This patch replaces bit shifting on 1 with the BIT(x) macro
>     >
>     > This was done with coccinelle:
>     > @@ int g; @@
>     >
>     > -(1 << g)
>     > +BIT(g)
>     >
>     > Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
>     Something odd happened here as this is only a small proportion of the cases
>     that should be updated in this file.  There's one at the bottom of the
>     patch for starters!
> 
> 
> I didn't apply BIT(x) for mixed cases.I think I should drop this patch
> altogether but
> Greg has added it. Will it cause problems ? :(

Greg can always drop it :)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 4/6] Staging: iio: cdc: Prefer using the BIT macro Shraddha Barke <shraddha.6596@gmail.com> - 2015-09-10 18:40 +0200
  Re: [PATCH 4/6] Staging: iio: cdc: Prefer using the BIT macro Jonathan Cameron <jic23@kernel.org> - 2015-09-12 11:50 +0200
    Re: [PATCH 4/6] Staging: iio: cdc: Prefer using the BIT macro Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2015-09-12 17:50 +0200

csiph-web