Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1223389

Re: [PATCH v2 00/23] dmaengine/ARM: Merge the edma drivers into one

From Sekhar Nori <nsekhar@ti.com>
Newsgroups linux.kernel
Subject Re: [PATCH v2 00/23] dmaengine/ARM: Merge the edma drivers into one
Date 2015-09-12 13:30 +0200
Message-ID <q7Rah-7uC-7@gated-at.bofh.it> (permalink)
References <q7vCN-1rQ-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Friday 11 September 2015 05:56 PM, Peter Ujfalusi wrote:
> Hi,
> 
> Changes since v1:
> - Convert edma platform device registration to use platform_device_register_full
> - Moved the PM callback also to the dmaengine driver - missed in v1
> - Commit message added to:
>   ARM/dmaengine: edma: Remove limitation on the number of eDMA controllers
> - New patch which reads the flag for the channel mapping support in one place
> 
> Cover letter:
> 
> with this series the edma two driver setup will be changed to have only one
> driver to support eDMA3. The legacy edma interface will be removed and eDMA can
> only be used via dmaengine API from this point on.
> In order to do the merge the following improvements has been done:
> - One driver instance per eDMA:
>  - Any number of eDMA instances are supported (both legacy and DT boot)
> - Not relying on global variables, arrays, etc
> - Code simplification and optimizations in several places
> 
> This change will also help us to do bigger changes in the eDMA driver since,
> since now we have only one driver to work with.
> 
> The series has been tested on:
> da850-evm (OMAP-L138)
> - with legacy and DT boot (both eDMA0 and eDMA1 is enabled)
> - In code swapping the eDMA instances in legacy mode to make sure the second
>   instance is handled correctly.
> 
> am335x-evmsk
> - DT boot
> 
> I think this series could go via the dmaengine tree. Changes are trivial under
> arch/arm/

I looked at the series, it looks pretty good. Thanks for getting it done!

No problem with entire series going through dmaengine. The week after
next, when I am back in office, I would like to test on DM365 as well.
But really no need to wait for it if the series is ready otherwise.

Thanks,
Sekhar

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v2 00/23] dmaengine/ARM: Merge the edma drivers into one Peter Ujfalusi <peter.ujfalusi@ti.com> - 2015-09-11 14:30 +0200
  [PATCH v2 09/23] ARM: davinci: Use platform_device_register_full() to create pdev for eDMA Peter Ujfalusi <peter.ujfalusi@ti.com> - 2015-09-11 14:30 +0200
  [PATCH v2 18/23] dmaengine: edma: Print warning when linking slots from different eDMA Peter Ujfalusi <peter.ujfalusi@ti.com> - 2015-09-11 14:30 +0200
  [PATCH v2 07/23] ARM/dmaengine: edma: Public API to use private struct pointer Peter Ujfalusi <peter.ujfalusi@ti.com> - 2015-09-11 14:40 +0200
  [PATCH v2 19/23] dmaengine: edma: Consolidate the comments for functions Peter Ujfalusi <peter.ujfalusi@ti.com> - 2015-09-11 14:40 +0200
  [PATCH v2 08/23] ARM/dmaengine: edma: Remove limitation on the number of eDMA controllers Peter Ujfalusi <peter.ujfalusi@ti.com> - 2015-09-11 14:40 +0200
  [PATCH v2 10/23] ARM: davinci: Add set dma_mask to eDMA devices Peter Ujfalusi <peter.ujfalusi@ti.com> - 2015-09-11 14:40 +0200
  [PATCH v2 17/23] dmaengine: edma: Use the edma_write_slot instead open coded memcpy_toio Peter Ujfalusi <peter.ujfalusi@ti.com> - 2015-09-11 14:40 +0200
  [PATCH v2 04/23] ARM: davinci/common: Convert edma driver to handle one eDMA instance per driver Peter Ujfalusi <peter.ujfalusi@ti.com> - 2015-09-11 14:40 +0200
    Re: [PATCH v2 04/23] ARM: davinci/common: Convert edma driver to  handle one eDMA instance per driver Peter Ujfalusi <peter.ujfalusi@ti.com> - 2015-09-18 13:50 +0200
  [PATCH v2 12/23] dmaengine: edma: Allocate memory dynamically for bitmaps and structures Peter Ujfalusi <peter.ujfalusi@ti.com> - 2015-09-11 14:40 +0200
  [PATCH v2 02/23] ARM: common: edma: Remove unused functions Peter Ujfalusi <peter.ujfalusi@ti.com> - 2015-09-11 14:40 +0200
  [PATCH v2 06/23] ARM: common: edma: Internal API to use pointer to 'struct edma' Peter Ujfalusi <peter.ujfalusi@ti.com> - 2015-09-11 14:40 +0200
  Re: [PATCH v2 00/23] dmaengine/ARM: Merge the edma drivers into one Sekhar Nori <nsekhar@ti.com> - 2015-09-12 13:30 +0200
  Re: [PATCH v2 11/23] ARM/dmaengine: edma: Merge the two drivers  under drivers/dmaengine Tony Lindgren <tony@atomide.com> - 2015-09-14 18:20 +0200
    Re: [PATCH v2 11/23] ARM/dmaengine: edma: Merge the two drivers under  drivers/dmaengine Peter Ujfalusi <peter.ujfalusi@ti.com> - 2015-09-15 08:50 +0200

csiph-web