Re: [PATCH 5/6] MIPS: CONFIG_MIPS_MT_SMP should depend upon CPU_MIPSR2

From	Ralf Baechle <ralf@linux-mips.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 5/6] MIPS: CONFIG_MIPS_MT_SMP should depend upon CPU_MIPSR2
Date	2015-09-12 12:20 +0200
Message-ID	<q7Q4x-5XR-5@gated-at.bofh.it> (permalink)
References	<pUfFw-6J8-3@gated-at.bofh.it> <pUfFw-6J8-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Aug 05, 2015 at 03:42:39PM -0700, Paul Burton wrote:

> The MT ASE cannot be used with CPUs that implement older releases of the
> MIPS architecture than release 2, and is replaced in release 6. Encode
> these constraints in Kconfig to ensure that MT code is only built as
> part of kernels targeting an appropriate revision of the architecture.
> 
> Signed-off-by: Paul Burton <paul.burton@imgtec.com>
> Cc: Markos Chandras <markos.chandras@imgtec.com>
> Cc: <stable@vger.kernel.org> # 3.16+
> ---
> 
>  arch/mips/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> index cee5f93..ef248cf 100644
> --- a/arch/mips/Kconfig
> +++ b/arch/mips/Kconfig
> @@ -2114,7 +2114,7 @@ config CPU_R4K_CACHE_TLB
>  
>  config MIPS_MT_SMP
>  	bool "MIPS MT SMP support (1 TC on each available VPE)"
> -	depends on SYS_SUPPORTS_MULTITHREADING
> +	depends on SYS_SUPPORTS_MULTITHREADING && CPU_MIPSR2

Right now this line is

depends on SYS_SUPPORTS_MULTITHREADING && !CPU_MIPSR6

which I believe is correct.  The MT SMP support aka VSMP had been
carefully crafted to work on older ASEs that is all use of MIPS MT
instructions or features was carefully protected by cpu_has_mipsmt
or similar.

  Ralf
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 5/6] MIPS: CONFIG_MIPS_MT_SMP should depend upon  CPU_MIPSR2 Ralf Baechle <ralf@linux-mips.org> - 2015-09-12 12:20 +0200
  Re: [PATCH 5/6] MIPS: CONFIG_MIPS_MT_SMP should depend upon  CPU_MIPSR2 Paul Burton <paul.burton@imgtec.com> - 2015-09-12 17:20 +0200

csiph-web