Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1223349

Re: [RFC][PATCH 2/3] perf: Fix u16 overflows

Show all headers | View raw

* Peter Zijlstra <peterz@infradead.org> wrote:

> Vince reported that its possible to overflow the various size fields
> and get weird stuff if you stick too many events in a group.
> 
> Put a lid on this by requiring the fixed record size not exceed 16k.
> This is still a fair amount of events (silly amount really) and leaves
> plenty room for callchains and stack dwarves while also avoiding
> overflowing the u16 variables.

Does this leave a natural ABI extension route here, in case in the future it 
becomes a problem? We should take aside a value to mean 'larger record' or such?

Could we list exactly which fields this concerns, in which structures?

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC][PATCH 2/3] perf: Fix u16 overflows Peter Zijlstra <peterz@infradead.org> - 2015-09-10 18:30 +0200
  Re: [RFC][PATCH 2/3] perf: Fix u16 overflows Ingo Molnar <mingo@kernel.org> - 2015-09-12 10:20 +0200
    Re: [RFC][PATCH 2/3] perf: Fix u16 overflows Peter Zijlstra <peterz@infradead.org> - 2015-09-14 11:10 +0200
      Re: [RFC][PATCH 2/3] perf: Fix u16 overflows Ingo Molnar <mingo@kernel.org> - 2015-09-14 11:40 +0200

csiph-web