Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1223127

Re: [PATCH] bnx2x: use ktime_get_seconds() for timestamp

Show all headers | View raw

From: Arnd Bergmann <arnd@arndb.de>
Date: Fri, 11 Sep 2015 11:33:01 +0200

> commit c48f350ff5e7 "bnx2x: Add MFW dump support" added the
> bnx2x_update_mfw_dump() function that reads the current time and stores
> it in a 32-bit field that gets passed into a buffer in a fixed format.
> 
> This is potentially broken when the epoch overflows in 2038, and
> otherwise overflows in 2106. As we're trying to avoid uses of
> struct timeval for this reason, I noticed the addition of this
> function, and tried to rewrite it in a way that is more explicit
> about the overflow and that will keep working once we deprecate
> struct timeval.
> 
> I assume that it is not possible to change the ABI any more, otherwise
> we should try to use a 64-bit field for the seconds right away.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] bnx2x: use ktime_get_seconds() for timestamp Arnd Bergmann <arnd@arndb.de> - 2015-09-11 11:40 +0200
  RE: [PATCH] bnx2x: use ktime_get_seconds() for timestamp Yuval Mintz <Yuval.Mintz@qlogic.com> - 2015-09-11 12:30 +0200
  Re: [PATCH] bnx2x: use ktime_get_seconds() for timestamp David Miller <davem@davemloft.net> - 2015-09-12 00:10 +0200

csiph-web