Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1223033

Re: [PATCH] lib/string_helpers.c: fix infinite loop in string_get_size()

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Thu, 2015-09-10 at 16:08 -0700, Andrew Morton wrote:
> On Fri,  4 Sep 2015 14:56:33 +0200 Vitaly Kuznetsov <vkuznets@redhat.com> wrote:
> 
> > string_get_size(1, 512, 0, ..., ...) call results in an infinite loop. The
> > problem is that if size == 0 when we start calculating sf_cap this loop
> > will never end.
> > 
> > The caller causing the issue is sd_read_capacity(), the problem was noticed
> > on Hyper-V.
> 
> When fixing bugs, please provide enough info for others to be able to
> understand which kernel version(s) need the fix.  In this case: what
> end-user action triggers this bug?  (iow, how does sdkp->capacity
> become zero?)

Any more details.  The attached programme, which is cut straight out of
the algorithm in string_helpers.c and modified for a C environment
slightly (only in do_div and the typedefs) produces this

hello
STRING IS 512 B

With your input, so I don't think the problem is where you think it is.

James

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] lib/string_helpers.c: fix infinite loop in  string_get_size() Andrew Morton <akpm@linux-foundation.org> - 2015-09-11 01:10 +0200
  Re: [PATCH] lib/string_helpers.c: fix infinite loop in  string_get_size() James Bottomley <jbottomley@odin.com> - 2015-09-11 20:40 +0200
    Re: [PATCH] lib/string_helpers.c: fix infinite loop in  string_get_size() Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2015-09-14 11:10 +0200
      Re: [PATCH] lib/string_helpers.c: fix infinite loop in string_get_size() Vitaly Kuznetsov <vkuznets@redhat.com> - 2015-09-14 14:50 +0200
        Re: [PATCH] lib/string_helpers.c: fix infinite loop in  string_get_size() Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2015-09-14 16:40 +0200
    Re: [PATCH] lib/string_helpers.c: fix infinite loop in string_get_size() Vitaly Kuznetsov <vkuznets@redhat.com> - 2015-09-14 11:20 +0200

csiph-web