Re: [PATCH v2] arm/xen: Enable user access to the kernel before issuing a privcmd call

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!weretis.net!feeder1.news.weretis.net!newsfeed.CARNet.hr!news.spin.it!bofh.it!news.nic.it!robomod
From	Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] arm/xen: Enable user access to the kernel before issuing a privcmd call
Date	Fri, 11 Sep 2015 20:00:02 +0200
Message-ID	<q7AMa-sV-29@gated-at.bofh.it> (permalink)
References	<q7zGq-7k9-23@gated-at.bofh.it> <q7zZM-7Wu-23@gated-at.bofh.it> <q7AsQ-5G-13@gated-at.bofh.it> <q7AsR-5G-59@gated-at.bofh.it> <q7AM9-sV-1@gated-at.bofh.it>
X-Original-To	Russell King - ARM Linux <linux@arm.linux.org.uk>
X-Ironport-Av	E=Sophos;i="5.17,512,1437436800"; d="scan'208";a="303053343"
X-X-Sender	sstabellini@kaball.uk.xensource.com
User-Agent	Alpine 2.02 (DEB 1266 2009-07-14)
MIME-Version	1.0
Content-Type	text/plain; charset="US-ASCII"
X-Dlp	MIA2
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	56
Organization	linux.* mail to news gateway
X-Original-Cc	Julien Grall <julien.grall@citrix.com>, <ian.campbell@citrix.com>, <stefano.stabellini@eu.citrix.com>, Riku Voipio <riku.voipio@linaro.org>, <linux-kernel@vger.kernel.org>, <xen-devel@lists.xenproject.org>, <linux-arm-kernel@lists.infradead.org>
X-Original-Date	Fri, 11 Sep 2015 18:56:50 +0100
X-Original-Message-ID	<alpine.DEB.2.02.1509111856020.2672@kaball.uk.xensource.com>
X-Original-References	<1441988759-4572-1-git-send-email-julien.grall@citrix.com> <20150911170027.GX21084@n2100.arm.linux.org.uk> <55F3102B.3090309@citrix.com> <55F31105.6070305@citrix.com> <20150911175107.GY21084@n2100.arm.linux.org.uk>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1223011

Show key headers only | View raw

On Fri, 11 Sep 2015, Russell King - ARM Linux wrote:
> On Fri, Sep 11, 2015 at 06:36:05PM +0100, Julien Grall wrote:
> > On 11/09/15 18:32, Julien Grall wrote:
> > > On 11/09/15 18:00, Russell King - ARM Linux wrote:
> > >> On Fri, Sep 11, 2015 at 05:25:59PM +0100, Julien Grall wrote:
> > >>> +	/*
> > >>> +	 * Privcmd calls are issued by the userspace. We need to allow the
> > >>> +	 * kernel to access the userspace memory before issuing the hypercall.
> > >>> +	 */
> > >>> +	uaccess_enable r4
> > >>> +
> > >>> +	/* r4 is loaded now as we use it as scratch register before */
> > >>>  	ldr r4, [sp, #4]
> > >>
> > >> As I mentioned in one of my previous mails, "ip" should be safe to use
> > >> here - it's a caller-corrupted register, just like r0-r3 and lr.  So,
> > >> you could do:
> > >>
> > >> 	ldr r4, [sp, #4]
> > >> +	uaccess_enable ip
> > > 
> > > The register ip (aka r12) is used to store the hypercall number. So we
> > > can't reuse it as scratch register.
> > > 
> > > The easiest one is r4.
> > > 
> > >>
> > >> which fractionally tightens the window.
> > >>
> > >> However, there's nothing actually wrong with your version - there's no
> > >> way we could've got this far with sp pointing at userspace.
> > >>
> > >> I'm happy with either version, so:
> > >>
> > >> Acked-by: Russell King <rmk+kernel@arm.linux.org.uk>
> > >>
> > >> How do you want to handle the patch?  I already have some other uaccess
> > >> fixes queued up to send to Linus before the merge window closes.
> > 
> > Forgot to answer to this bits. I was thinking to ask Stefano carrying
> > the patch in xentip. Although it won't go until rc1.
> > 
> > I don't mind if it's going earlier in Linux/master.
> 
> Thanks, I've applied your patch as-is now.

That's fine by me, the patch looks good.

Thanks,

Stefano
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH v2] arm/xen: Enable user access to the kernel before issuing a privcmd call Julien Grall <julien.grall@citrix.com> - 2015-09-11 18:50 +0200
  Re: [PATCH v2] arm/xen: Enable user access to the kernel before  issuing a privcmd call Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-09-11 19:10 +0200
    Re: [PATCH v2] arm/xen: Enable user access to the kernel before issuing  a privcmd call Julien Grall <julien.grall@citrix.com> - 2015-09-11 19:40 +0200
      Re: [PATCH v2] arm/xen: Enable user access to the kernel before issuing  a privcmd call Julien Grall <julien.grall@citrix.com> - 2015-09-11 19:40 +0200
        Re: [PATCH v2] arm/xen: Enable user access to the kernel before  issuing a privcmd call Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-09-11 20:00 +0200
          Re: [PATCH v2] arm/xen: Enable user access to the kernel before  issuing a privcmd call Stefano Stabellini <stefano.stabellini@eu.citrix.com> - 2015-09-11 20:00 +0200
            Re: [PATCH v2] arm/xen: Enable user access to the kernel before  issuing a privcmd call Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-09-11 20:10 +0200
              Re: [PATCH v2] arm/xen: Enable user access to the kernel before  issuing a privcmd call Stefano Stabellini <stefano.stabellini@eu.citrix.com> - 2015-09-14 11:40 +0200
                Re: [PATCH v2] arm/xen: Enable user access to the kernel before  issuing a privcmd call Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-09-14 12:10 +0200
                Re: [PATCH v2] arm/xen: Enable user access to the kernel before  issuing a privcmd call Stefano Stabellini <stefano.stabellini@eu.citrix.com> - 2015-09-14 13:20 +0200
    Re: [PATCH v2] arm/xen: Enable user access to the kernel before issuing  a privcmd call Julien Grall <julien.grall@citrix.com> - 2015-09-11 20:00 +0200

csiph-web