Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1222166
| From | LABBE Corentin <clabbe.montjoie@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH v2 2/5] stmmac: replace hardcoded function name by __func__ |
| Date | 2015-09-10 14:40 +0200 |
| Message-ID | <q79iX-1uR-43@gated-at.bofh.it> (permalink) |
| References | <q79iW-1uR-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Some printing have the function name hardcoded. It is better to use __func__ instead. Signed-off-by: LABBE Corentin <clabbe.montjoie@gmail.com> --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c index 1cfce6e..b016f04 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c @@ -831,7 +831,7 @@ static int stmmac_init_phy(struct net_device *dev) snprintf(phy_id_fmt, MII_BUS_ID_SIZE + 3, PHY_ID_FMT, bus_id, priv->plat->phy_addr); - netdev_dbg(priv->dev, "stmmac_init_phy: trying to attach to %s\n", + netdev_dbg(priv->dev, "%s: trying to attach to %s\n", __func__, phy_id_fmt); phydev = phy_connect(dev, phy_id_fmt, &stmmac_adjust_link, @@ -862,8 +862,8 @@ static int stmmac_init_phy(struct net_device *dev) phy_disconnect(phydev); return -ENODEV; } - netdev_dbg(priv->dev, "stmmac_init_phy: %s: attached to PHY (UID 0x%x) Link = %d\n", - dev->name, phydev->phy_id, phydev->link); + netdev_dbg(priv->dev, "%s: %s: attached to PHY (UID 0x%x) Link = %d\n", + __func__, dev->name, phydev->phy_id, phydev->link); priv->phydev = phydev; -- 2.4.6 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
stmmac: improve logging LABBE Corentin <clabbe.montjoie@gmail.com> - 2015-09-10 14:40 +0200
[PATCH v2 5/5] stmmac: replace if (netif_msg_type) by their netif_xxx counterpart LABBE Corentin <clabbe.montjoie@gmail.com> - 2015-09-10 14:40 +0200
Re: [PATCH v2 5/5] stmmac: replace if (netif_msg_type) by their netif_xxx counterpart Joe Perches <joe@perches.com> - 2015-09-10 18:30 +0200
[PATCH v2 2/5] stmmac: replace hardcoded function name by __func__ LABBE Corentin <clabbe.montjoie@gmail.com> - 2015-09-10 14:40 +0200
Re: stmmac: improve logging David Miller <davem@davemloft.net> - 2015-09-15 22:40 +0200
csiph-web