Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1222094

Re: [PATCH] futex: eliminate cache miss from futex_hash()

Show all headers | View raw

On Wed, 09 Sep 2015, Rasmus Villemoes wrote:

>futex_hash() references two global variables: the base pointer
>futex_queues and the size of the array futex_hashsize. The latter is
>marked __read_mostly, while the former is not, so they are likely to
>end up very far from each other. This means that futex_hash() is
>likely to encounter two cache misses.
>
>We could mark futex_queues as __read_mostly as well, but that doesn't
>guarantee they'll end up next to each other (and even if they do, they
>may still end up in different cache lines). So put the two variables
>in a small singleton struct with sufficient alignment and mark that as
>__read_mostly.

This really doesn't have much practical effect -- not even on larger
boxes, where such things matter. For instance, I ran the patch on a
60-core IvyBridge with 'perf-bench futex', for which futex-hash
particularly benefits in good data layout (ie our current smp alignment).

http://linux-scalability.org/futex-__futex_data/

I think we should leave it as is.

Thanks,
Davidlohr
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] futex: eliminate cache miss from futex_hash() Rasmus Villemoes <linux@rasmusvillemoes.dk> - 2015-09-09 23:40 +0200
  Re: [PATCH] futex: eliminate cache miss from futex_hash() Davidlohr Bueso <dave@stgolabs.net> - 2015-09-10 12:30 +0200
    Re: [PATCH] futex: eliminate cache miss from futex_hash() Ingo Molnar <mingo@kernel.org> - 2015-09-12 12:00 +0200

csiph-web