Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1222024

Re: [PATCH] thermal: Fix thermal_zone_of_sensor_register to match documentation

Show all headers | View raw

On Tue, Sep 08, 2015 at 02:51:12PM +0100, Punit Agrawal wrote:
> thermal_zone_of_sensor_register is documented as returning a pointer
> to either a valid thermal_zone_device on success, or a corresponding
> ERR_PTR() value.
> 
> In contrast, the function returns NULL when THERMAL_OF is configured
> off. Fix this.
> 
> Signed-off-by: Punit Agrawal <punit.agrawal@arm.com>
> Acked-by: Guenter Roeck <linux@roeck-us.net>
> Cc: Eduardo Valentin <edubezval@gmail.com>
> Cc: Zhang Rui <rui.zhang@intel.com>
> ---
> Hi Eduardo, Rui,
> 
> This patch has been on the list without any objection for sometime [0]
>  now. Could you pick this up for the next rc please?
> 
> Thanks,
> Punit
> 
> [0] http://thread.gmane.org/gmane.linux.kernel/2011466/focus=2013175
> 
>  include/linux/thermal.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

FWIW,

Reviewed-by: Javi Merino <javi.merino@arm.com>

Cheers,
Javi

> diff --git a/include/linux/thermal.h b/include/linux/thermal.h
> index 037e9df..f344e51 100644
> --- a/include/linux/thermal.h
> +++ b/include/linux/thermal.h
> @@ -364,7 +364,7 @@ static inline struct thermal_zone_device *
>  thermal_zone_of_sensor_register(struct device *dev, int id, void *data,
>  				const struct thermal_zone_of_device_ops *ops)
>  {
> -	return NULL;
> +	return ERR_PTR(-ENODEV);
>  }
>  
>  static inline
> -- 
> 2.5.0
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] thermal: Fix thermal_zone_of_sensor_register to match documentation Punit Agrawal <punit.agrawal@arm.com> - 2015-09-08 16:00 +0200
  Re: [PATCH] thermal: Fix thermal_zone_of_sensor_register to match  documentation Javi Merino <javi.merino@arm.com> - 2015-09-10 10:50 +0200
    RE: [PATCH] thermal: Fix thermal_zone_of_sensor_register to match  documentation "Zhang, Rui" <rui.zhang@intel.com> - 2015-09-10 10:50 +0200

csiph-web