Re: [PATCH 2/2] staging: lustre: lov: remove always false condition

From	Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] staging: lustre: lov: remove always false condition
Date	2015-09-08 19:50 +0200
Message-ID	<q6vbQ-2PL-31@gated-at.bofh.it> (permalink)
References	<q6tWq-16N-9@gated-at.bofh.it> <q6tWq-16N-7@gated-at.bofh.it> <q6upt-1Fu-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Sep 08, 2015 at 09:53:09AM -0700, Joe Perches wrote:
> On Tue, 2015-09-08 at 21:53 +0530, Sudip Mukherjee wrote:
> >  		if (qctl->qc_valid == QC_OSTIDX) {
> > -			if (qctl->qc_idx < 0 || count <= qctl->qc_idx)
> > +			if (count <= qctl->qc_idx)
> 
> Perhaps this test would be clearer reversed too
> 
> 			if (qctl->qc_idx >= count)
There are more such comparison in that file, like:
1) if (ost_idx >= lov->desc.ld_tgt_count)
2) if (index >= lov->lov_tgt_size)
and some more.
And if I include it in this patch then it will become separate change.
I will better send a separate patch for this.

Regards
Sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 2/2] staging: lustre: lov: remove always false condition Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-09-08 18:30 +0200
  Re: [PATCH 2/2] staging: lustre: lov: remove always false condition Joe Perches <joe@perches.com> - 2015-09-08 19:00 +0200
    Re: [PATCH 2/2] staging: lustre: lov: remove always false condition Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-09-08 19:50 +0200

csiph-web