Groups > linux.kernel > #1220994

Re: [RFC 5/5] HACK: serial: move pl011 initcall to device_initcall

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Leif Lindholm <leif.lindholm@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [RFC 5/5] HACK: serial: move pl011 initcall to device_initcall
Date	Tue, 08 Sep 2015 19:00:03 +0200
Message-ID	<q6upt-1Fu-17@gated-at.bofh.it> (permalink)
References	<q6qvv-4v7-3@gated-at.bofh.it> <q6qvw-4v7-27@gated-at.bofh.it> <q6qFc-4GE-1@gated-at.bofh.it>
X-Original-To	Mark Rutland <mark.rutland@arm.com>
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; bh=CERjPxMnl7gf8ZtTXoK6ir2fMeAm7oyfAoE4oDcCbs8=; b=PPfGJHG0gCUGaPJlc6wzIaXpTzanvZClHOhgj59/EXQ9pO/k5W2E0Vuh5Hm+2CUiV0 qw2dDjmtDNZ5KiS5qadRZHbo8BucmtMN4Q1VZaPQFT7k6qG/o/O1/2zt+uA9W7ILFyqC sb4v1u/BPdERNirsS9WDt6RK1UzqB3rVXpP3eABa50jQmiZL9XkP2i245/zDmGj3sQMJ G/lZUYXJAduBsxdxNDH+RxtHJOwkCvTJC0q8qQedvRvcUtR09Q9q5r6ygBmfl4PExKBX 04BbnnlrZpYvQhMU/gg542X0gLuP7sSjuexz/5l/Y5Ai6v8+LyxJo/wsvKwRWuAQTnjU 3ioQ==
X-Gm-Message-State	ALoCoQm+VFVzW/pbM79OSVg2wD3O8dtW132z6WKjB8OZMGN8wHWI1zaR+iARbDhVRVvleGBOXWov
X-Received	by 10.180.83.40 with SMTP id n8mr46908015wiy.14.1441731327636; Tue, 08 Sep 2015 09:55:27 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.21 (2010-09-15)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	40
Organization	linux.* mail to news gateway
X-Original-Cc	"linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>, "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "al.stone@linaro.org" <al.stone@linaro.org>, "torez@redhat.com" <torez@redhat.com>, "jcm@redhat.com" <jcm@redhat.com>, "graeme.gregory@linaro.org" <graeme.gregory@linaro.org>, "linaro-acpi@lists.linaro.org" <linaro-acpi@lists.linaro.org>, "lv.zheng@intel.com" <lv.zheng@intel.com>
X-Original-Date	Tue, 8 Sep 2015 17:55:24 +0100
X-Original-Message-ID	<20150908165524.GO10728@bivouac.eciton.net>
X-Original-References	<1441716217-23786-1-git-send-email-leif.lindholm@linaro.org> <1441716217-23786-6-git-send-email-leif.lindholm@linaro.org> <20150908125608.GD20562@leverpostej>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1220994

Show key headers only | View raw

On Tue, Sep 08, 2015 at 01:56:08PM +0100, Mark Rutland wrote:
> On Tue, Sep 08, 2015 at 01:43:37PM +0100, Leif Lindholm wrote:
> > ---
> >  drivers/tty/serial/amba-pl011.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/tty/serial/amba-pl011.c b/drivers/tty/serial/amba-pl011.c
> > index 452dbba..31cf985 100644
> > --- a/drivers/tty/serial/amba-pl011.c
> > +++ b/drivers/tty/serial/amba-pl011.c
> > @@ -2806,7 +2806,7 @@ static void __exit pl011_exit(void)
> >   * While this can be a module, if builtin it's most likely the console
> >   * So let's leave module_exit but move module_init to an earlier place
> >   */
> > -arch_initcall(pl011_init);
> > +device_initcall(pl011_init);
> >  module_exit(pl011_exit);
> 
> What's the ordering constraint that you're trying to solve with this?

Basically that _CRS is not available until the ACPI subsystem is up -
so when uart_add_one_port() calls acpi_console_check(), that function
looks for a match against variables that have not been set yet.

> The cover didn't mention anything, and there's no commit message.

That's because I really don't want it committed :)
 
> Mark.
> 
> >  
> >  MODULE_AUTHOR("ARM Ltd/Deep Blue Solutions Ltd");
> > -- 
> > 2.1.4
> > 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RFC 5/5] HACK: serial: move pl011 initcall to device_initcall Leif Lindholm <leif.lindholm@linaro.org> - 2015-09-08 14:50 +0200
  Re: [RFC 5/5] HACK: serial: move pl011 initcall to device_initcall Mark Rutland <mark.rutland@arm.com> - 2015-09-08 15:00 +0200
    Re: [RFC 5/5] HACK: serial: move pl011 initcall to device_initcall Leif Lindholm <leif.lindholm@linaro.org> - 2015-09-08 19:00 +0200

csiph-web