Groups > linux.kernel > #1220872

[tip:perf/core] perf session: Don't call dump_sample() when evsel is NULL

Path	csiph.com!goblin2!goblin.stu.neva.ru!aioe.org!bofh.it!news.nic.it!robomod
From	tip-bot for Kan Liang <tipbot@zytor.com>
Newsgroups	linux.kernel
Subject	[tip:perf/core] perf session: Don't call dump_sample() when evsel is NULL
Date	Tue, 08 Sep 2015 16:40:03 +0200
Message-ID	<q6sdZ-71F-49@gated-at.bofh.it> (permalink)
References	<q4IGf-4OA-27@gated-at.bofh.it>
X-Original-To	linux-tip-commits@vger.kernel.org
Reply-To	eranian@google.com, ak@linux.intel.com, hpa@zytor.com, kan.liang@intel.com, tglx@linutronix.de, namhyung@kernel.org, acme@redhat.com, adrian.hunter@intel.com, luto@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org, a.p.zijlstra@chello.nl, mingo@kernel.org, mark.rutland@arm.com
Git-Commit-ID	1b29ac59b1d692c06ec543a5f35e0d9ebb98e003
X-Mailer	tip-git-log-daemon
Robot-ID	<tip-bot.git.kernel.org>
Robot-Unsubscribe	Contact <mailto:hpa@kernel.org> to get blacklisted from these emails
MIME-Version	1.0
Content-Transfer-Encoding	8bit
Content-Type	text/plain; charset=UTF-8
Content-Disposition	inline
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	48
Organization	linux.* mail to news gateway
X-Original-Cc	acme@redhat.com, jolsa@kernel.org, luto@kernel.org, adrian.hunter@intel.com, linux-kernel@vger.kernel.org, mark.rutland@arm.com, mingo@kernel.org, a.p.zijlstra@chello.nl, eranian@google.com, ak@linux.intel.com, hpa@zytor.com, kan.liang@intel.com, tglx@linutronix.de, namhyung@kernel.org
X-Original-Date	Tue, 8 Sep 2015 07:38:25 -0700
X-Original-Message-ID	<tip-1b29ac59b1d692c06ec543a5f35e0d9ebb98e003@git.kernel.org>
X-Original-References	<1441283463-51050-5-git-send-email-kan.liang@intel.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1220872

Show key headers only | View raw

Commit-ID:  1b29ac59b1d692c06ec543a5f35e0d9ebb98e003
Gitweb:     http://git.kernel.org/tip/1b29ac59b1d692c06ec543a5f35e0d9ebb98e003
Author:     Kan Liang <kan.liang@intel.com>
AuthorDate: Thu, 3 Sep 2015 08:31:00 -0400
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Fri, 4 Sep 2015 12:01:04 -0300

perf session: Don't call dump_sample() when evsel is NULL

Need to check evsel before passing it to dump_sample().

Signed-off-by: Kan Liang <kan.liang@intel.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/r/1441283463-51050-5-git-send-email-kan.liang@intel.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/util/session.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c
index 61669be..23fed17 100644
--- a/tools/perf/util/session.c
+++ b/tools/perf/util/session.c
@@ -1080,11 +1080,11 @@ static int machines__deliver_event(struct machines *machines,
 
 	switch (event->header.type) {
 	case PERF_RECORD_SAMPLE:
-		dump_sample(evsel, event, sample);
 		if (evsel == NULL) {
 			++evlist->stats.nr_unknown_id;
 			return 0;
 		}
+		dump_sample(evsel, event, sample);
 		if (machine == NULL) {
 			++evlist->stats.nr_unprocessable_samples;
 			return 0;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[tip:perf/core] perf session: Don't call dump_sample()   when evsel is NULL tip-bot for Kan Liang <tipbot@zytor.com> - 2015-09-08 16:40 +0200

csiph-web