Groups > linux.kernel > #1220825

Re: [PATCH] ftrace: allow dumping traces without tracking trace started cpus

From	Steven Rostedt <rostedt@goodmis.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ftrace: allow dumping traces without tracking trace started cpus
Date	2015-09-08 16:20 +0200
Message-ID	<q6rUC-6Ec-23@gated-at.bofh.it> (permalink)
References	<q52lB-7Jv-25@gated-at.bofh.it> <q5Ehb-2V1-23@gated-at.bofh.it> <q5JgR-1vn-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sun, 06 Sep 2015 10:29:43 -0400
Sasha Levin <sasha.levin@oracle.com> wrote:


> > So it is safe to call the function cpumask_test_cpu without doing
> > checking.
> 
> Can you point me to exactly where trace_init_global_iter() initializes
> iter->started?

Wouldn't the better solution be to initialize it in that function,
instead of checking if it is NULL? I think that's the true fix.
"started" should not be ignored.

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] ftrace: allow dumping traces without tracking trace  started cpus Steven Rostedt <rostedt@goodmis.org> - 2015-09-08 16:20 +0200
  Re: [PATCH] ftrace: allow dumping traces without tracking trace started  cpus Sasha Levin <sasha.levin@oracle.com> - 2015-09-08 16:20 +0200
    Re: [PATCH] ftrace: allow dumping traces without tracking trace  started cpus Steven Rostedt <rostedt@goodmis.org> - 2015-09-08 17:40 +0200

csiph-web