Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1220641
| From | Vaibhav Hiremath <vaibhav.hiremath@linaro.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH-v2 5/7] mmc: sdhci-pxav3: Fix HS200 mode support |
| Date | 2015-09-08 11:40 +0200 |
| Message-ID | <q6nxD-ij-15@gated-at.bofh.it> (permalink) |
| References | <q62Mx-47x-7@gated-at.bofh.it> <q62My-47x-13@gated-at.bofh.it> <q6l2O-55D-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tuesday 08 September 2015 12:23 PM, Jisheng Zhang wrote: > On Mon, 7 Sep 2015 16:48:39 +0530 > Vaibhav Hiremath <vaibhav.hiremath@linaro.org> wrote: > >> From: Kevin Liu <kliu5@marvell.com> >> >> IN case of MMC HS200 mode, current code does not enable >> SD_CE_ATA_2.MMC_HS200 & SD_CE_ATA_2.MMC_CARD bit configurations. >> >> So this patch updates the above bit fields correctly. >> >> Signed-off-by: Tim Wang <wangtt@marvell.com> >> Signed-off-by: Kevin Liu <kliu5@marvell.com> >> Signed-off-by: Vaibhav Hiremath <vaibhav.hiremath@linaro.org> >> --- >> Note: Unfortunately I do not have access to any other datasheets >> which uses sdhci-pxav3 driver, so quite not sure whether this would >> break any existing platform, probably NOT, as I do not see any >> references for this change. >> If anyone can confirm that would be really great. >> >> drivers/mmc/host/sdhci-pxav3.c | 17 +++++++++++++++++ >> 1 file changed, 17 insertions(+) >> >> diff --git a/drivers/mmc/host/sdhci-pxav3.c b/drivers/mmc/host/sdhci-pxav3.c >> index d933f75..6978810 100644 >> --- a/drivers/mmc/host/sdhci-pxav3.c >> +++ b/drivers/mmc/host/sdhci-pxav3.c >> @@ -57,6 +57,8 @@ >> #define SD_CE_ATA_1 0x10C >> >> #define SD_CE_ATA_2 0x10E >> +#define SD_CE_ATA2_HS200_EN BIT(10) >> +#define SD_CE_ATA2_MMC_MODE BIT(12) >> #define SDCE_MISC_INT BIT(2) >> #define SDCE_MISC_INT_EN BIT(1) >> >> @@ -330,6 +332,17 @@ static int pxav3_select_pinstate(struct sdhci_host *host, unsigned int uhs) >> return pinctrl_select_state(pxa->pinctrl, pinctrl); >> } >> >> +static int pxav3_select_hs200(struct sdhci_host *host) > > I didn't see why we need the return value, make it void would be better? > Fair enough. Will fix it in next version. Thanks, Vaibhav -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH-v2 5/7] mmc: sdhci-pxav3: Fix HS200 mode support Vaibhav Hiremath <vaibhav.hiremath@linaro.org> - 2015-09-07 13:30 +0200
Re: [PATCH-v2 5/7] mmc: sdhci-pxav3: Fix HS200 mode support Jisheng Zhang <jszhang@marvell.com> - 2015-09-08 09:00 +0200
Re: [PATCH-v2 5/7] mmc: sdhci-pxav3: Fix HS200 mode support Vaibhav Hiremath <vaibhav.hiremath@linaro.org> - 2015-09-08 11:40 +0200
csiph-web