Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1220468

Re: [PATCH] powerpc32: memcpy: only use dcbz once cache is enabled

Show all headers | View raw

On Mon, 2015-09-07 at 16:24 +0200, Christophe Leroy wrote:
> memcpy() uses instruction dcbz to speed up copy by not wasting time
> loading cache line with data that will be overwritten.
> Some platform like mpc52xx do no have cache active at startup and
> can therefore not use memcpy(). Allthough no part of the code
> explicitly uses memcpy(), GCC makes calls to it.
> 
> This patch modifies memcpy() such that at startup, the 'dcbz'
> instruction is replaced by 'dcbt' which is harmless if cache is not
> enabled, and which helps a bit (allthough not as much as dcbz) if
> cache is already enabled.
> 
> Once the initial MMU is setup, in machine_init() we patch memcpy()
> by replacing the temporary 'dcbt' by 'dcbz'
> 
> Reported-by: Michal Sojka <sojkam1@fel.cvut.cz>
> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>


Is there some reason you can't use the normal cpu feature sections? See
arch/powerpc/lib/memcpy_64.S for an example of what I mean.

cheers


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] powerpc32: memcpy: only use dcbz once cache is enabled Christophe Leroy <christophe.leroy@c-s.fr> - 2015-09-07 16:30 +0200
  Re: [PATCH] powerpc32: memcpy: only use dcbz once cache is enabled Michal Sojka <sojkam1@fel.cvut.cz> - 2015-09-07 17:00 +0200
  RE: [PATCH] powerpc32: memcpy: only use dcbz once cache is enabled David Laight <David.Laight@ACULAB.COM> - 2015-09-07 17:10 +0200
  Re: [PATCH] powerpc32: memcpy: only use dcbz once cache is enabled Michael Ellerman <mpe@ellerman.id.au> - 2015-09-08 06:00 +0200

csiph-web