Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1220463

Re: [v2,3/6] powerpc: kill mfvtb()

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Mon, Sep 07, 2015 at 07:29:42PM +1000, Michael Ellerman wrote:
> On Mon, 2015-24-08 at 11:20:25 UTC, Kevin Hao wrote:
> > This function is only used by get_vtb(). They are almost the same
> > except the reading from the real register. Move the mfspr() to
> > get_vtb() and kill the function mfvtb(). With this, we can eliminate
> > the use of cpu_has_feature() in very core header file like reg.h.
> > This is a preparation for the use of jump label for cpu_has_feature().
> 
> I don't mind this change. But can you elaborate a bit on the issue with using
> cpu_has_feature() in reg.h? Just so I can understand the problem.
> 
> I assume you ended up in a big mess of includes when you tried to include
> jump_label.h from reg.h?

Yes, the "jump_leabel.h" already include "reg.h" implicitly. 
   from arch/powerpc/include/asm/cache.h:6:0,
   from include/linux/cache.h:5,
   from include/linux/printk.h:8,
   from include/linux/kernel.h:14,
   from include/asm-generic/bug.h:13,
   from arch/powerpc/include/asm/bug.h:127,
   from include/linux/bug.h:4,
   from include/linux/jump_label.h:81,

So including "jump_label.h" from "reg.h" will cause a recursive header
inclusion problem.

Thanks,
Kevin

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/6] powerpc: use jump label for {cpu,mmu}_has_feature() Kevin Hao <haokexin@gmail.com> - 2015-08-24 13:30 +0200
  [PATCH v2 4/6] powerpc: move the cpu_has_feature to a separate file Kevin Hao <haokexin@gmail.com> - 2015-08-24 13:30 +0200
  [PATCH v2 5/6] powerpc: use the jump label for cpu_has_feature Kevin Hao <haokexin@gmail.com> - 2015-08-24 13:30 +0200
  [PATCH v2 3/6] powerpc: kill mfvtb() Kevin Hao <haokexin@gmail.com> - 2015-08-24 13:30 +0200
    Re: [v2,3/6] powerpc: kill mfvtb() Michael Ellerman <mpe@ellerman.id.au> - 2015-09-07 11:30 +0200
      Re: [v2,3/6] powerpc: kill mfvtb() Kevin Hao <haokexin@gmail.com> - 2015-09-08 05:00 +0200
  [PATCH v2 2/6] powerpc: invoke jump_label_init() in a much earlier stage Kevin Hao <haokexin@gmail.com> - 2015-08-24 13:30 +0200
  [PATCH v2 6/6] powerpc: use jump label for mmu_has_feature Kevin Hao <haokexin@gmail.com> - 2015-08-24 13:30 +0200
  Re: [PATCH v2 0/6] powerpc: use jump label for  {cpu,mmu}_has_feature() Ingo Molnar <mingo@kernel.org> - 2015-08-25 10:30 +0200

csiph-web