Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1220457

Re: [PATCH V2 6/9] cpufreq: ondemand: queue work for policy->cpus together

Show all headers | View raw

On 08-09-15, 03:33, Rafael J. Wysocki wrote:
> > +		/* Make sure the work is not canceled on policy->cpus */
> 
> I'm not sure what scenario can lead to that.  Care to explain?

CPUFREQ_GOV_STOP event called for the policy and so all its works
are in canceled state.

> > +		if (!dbs_info->cdbs.shared->policy)
> >  			continue;
> >  
> >  		next_sampling = jiffies + usecs_to_jiffies(new_rate);
> >  		appointed_at = dbs_info->cdbs.dwork.timer.expires;
> 
> For that to work we always need to do stuff for policy->cpus in sync.
> Do we?

Hmm, we are not in 100% sync for sure. Will check that again.

-- 
viresh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH V2 6/9] cpufreq: ondemand: queue work for policy->cpus together "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-09-08 03:10 +0200
  Re: [PATCH V2 6/9] cpufreq: ondemand: queue work for policy->cpus  together Viresh Kumar <viresh.kumar@linaro.org> - 2015-09-08 04:20 +0200
  Re: [PATCH V2 6/9] cpufreq: ondemand: queue work for policy->cpus  together Viresh Kumar <viresh.kumar@linaro.org> - 2015-09-08 04:20 +0200

csiph-web