Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1221811

Re: [PATCH] ipv6: fix ifnullfree.cocci warnings

Path csiph.com!au2pb.net!feeder.erje.net!1.eu.feeder.erje.net!nntpspool01.opticnetworks.net!aioe.org!bofh.it!news.nic.it!robomod
From David Miller <davem@davemloft.net>
Newsgroups linux.kernel
Subject Re: [PATCH] ipv6: fix ifnullfree.cocci warnings
Date Thu, 10 Sep 2015 02:30:01 +0200
Message-ID <q6XUt-2ct-3@gated-at.bofh.it> (permalink)
References <q6Wvo-8wd-13@gated-at.bofh.it> <q6Wvo-8wd-11@gated-at.bofh.it>
X-Original-To fengguang.wu@intel.com
X-Mailer Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO)
MIME-Version 1.0
Content-Type Text/Plain; charset=us-ascii
Content-Transfer-Encoding 7bit
X-Greylist Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 09 Sep 2015 17:21:28 -0700 (PDT)
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 22
Organization linux.* mail to news gateway
X-Original-Cc roopa@cumulusnetworks.com, kbuild-all@01.org, nikolay@cumulusnetworks.com, netdev@vger.kernel.org, kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net, linux-kernel@vger.kernel.org
X-Original-Date Wed, 09 Sep 2015 17:21:27 -0700 (PDT)
X-Original-Message-ID <20150909.172127.1527580619674387572.davem@davemloft.net>
X-Original-References <201509100609.fhjHrskx%fengguang.wu@intel.com> <20150909225712.GA6796@lkp-nex05>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1221811

Show key headers only | View raw


From: kbuild test robot <fengguang.wu@intel.com>
Date: Thu, 10 Sep 2015 06:57:12 +0800

> net/ipv6/route.c:2946:3-8: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values.
> 
>  NULL check before some freeing functions is not needed.
> 
>  Based on checkpatch warning
>  "kfree(NULL) is safe this check is probably not required"
>  and kfreeaddr.cocci by Julia Lawall.
> 
> Generated by: scripts/coccinelle/free/ifnullfree.cocci
> 
> CC: Roopa Prabhu <roopa@cumulusnetworks.com>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] ipv6: fix ifnullfree.cocci warnings kbuild test robot <fengguang.wu@intel.com> - 2015-09-10 01:00 +0200
  Re: [PATCH] ipv6: fix ifnullfree.cocci warnings David Miller <davem@davemloft.net> - 2015-09-10 02:30 +0200
  Re: [PATCH] ipv6: fix ifnullfree.cocci warnings roopa <roopa@cumulusnetworks.com> - 2015-09-10 07:10 +0200

csiph-web