Re: [RFC PATCH v4 2/3] vfio: platform: access device property as a list of strings

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Alex Williamson <alex.williamson@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH v4 2/3] vfio: platform: access device property as a list of strings
Date	Wed, 09 Sep 2015 22:50:02 +0200
Message-ID	<q6UtA-5EP-9@gated-at.bofh.it> (permalink)
References	<q6JRv-7mz-21@gated-at.bofh.it> <q6JRv-7mz-19@gated-at.bofh.it>
X-Original-To	Baptiste Reynal <b.reynal@virtualopensystems.com>
Content-Type	text/plain; charset="UTF-8"
MIME-Version	1.0
Content-Transfer-Encoding	7bit
X-Scanned-By	MIMEDefang 2.68 on 10.5.11.22
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	86
Organization	linux.* mail to news gateway
X-Original-Cc	kvmarm@lists.cs.columbia.edu, iommu@lists.linux-foundation.org, christoffer.dall@linaro.org, eric.auger@linaro.org, tech@virtualopensystems.com, Antonios Motakis <a.motakis@virtualopensystems.com>, "open list:VFIO PLATFORM DRIVER" <kvm@vger.kernel.org>, open list <linux-kernel@vger.kernel.org>
X-Original-Date	Wed, 09 Sep 2015 14:48:44 -0600
X-Original-Message-ID	<1441831724.20355.541.camel@redhat.com>
X-Original-References	<1441790231-22920-1-git-send-email-b.reynal@virtualopensystems.com> <1441790231-22920-3-git-send-email-b.reynal@virtualopensystems.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1221701

Show key headers only | View raw

On Wed, 2015-09-09 at 11:17 +0200, Baptiste Reynal wrote:
> From: Antonios Motakis <a.motakis@virtualopensystems.com>
> 
> Certain device properties (e.g. the device node name, the compatible
> string), are available as a list of strings (separated by the null
> terminating character). Let the VFIO user query this type of properties.
> 
> Signed-off-by: Antonios Motakis <a.motakis@virtualopensystems.com>
> Signed-off-by: Baptiste Reynal <b.reynal@virtualopensystems.com>
> 
> ---
> v3 -> v4:
>  - The list length is computed before strings copy. If the entire list
>    doesn't fit, no strings are copied to the user.
> ---
>  drivers/vfio/platform/properties.c | 43 +++++++++++++++++++++++++++++++++++++-
>  1 file changed, 42 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/vfio/platform/properties.c b/drivers/vfio/platform/properties.c
> index 98754c2..8bf9c8f 100644
> --- a/drivers/vfio/platform/properties.c
> +++ b/drivers/vfio/platform/properties.c
> @@ -22,7 +22,48 @@ static int dev_property_get_strings(struct device *dev, uint32_t *flags,
>  				    char *name, unsigned *lenp,
>  				    void __user *datap, unsigned long datasz)
>  {
> -	return -EINVAL;
> +	const char **val;
> +	int n, i, ret;
> +
> +	if (lenp == NULL)
> +		return -EFAULT;

Paranoia?

> +
> +	*lenp = 0;
> +
> +	n = device_property_read_string_array(dev, name, NULL, 0);
> +	if (n < 0)
> +		return n;
> +
> +	val = kcalloc(n, sizeof(char *), GFP_KERNEL);
> +	if (!val)
> +		return -ENOMEM;
> +
> +	ret = device_property_read_string_array(dev, name, val, n);
> +	if (ret < 0)
> +		goto out;
> +
> +	for (i = 0; i < n; i++)
> +		*lenp += strlen(val[i]) + 1;
> +
> +	if (datasz < *lenp) {
> +		ret = -E2BIG;
> +		goto out;
> +	}
> +
> +	for (i = 0; i < n; i++) {
> +		size_t len = strlen(val[i]) + 1;
> +
> +		if (copy_to_user(datap, val[i], strlen(val[i]) + 1)) {

No need to call strlen() again here

> +			ret = -EFAULT;
> +			goto out;
> +		}
> +
> +		datap += len;
> +	}
> +
> +out:
> +	kfree(val);
> +	return ret;
>  }
>  
>  static int dev_property_get_uint(struct device *dev, uint32_t *flags,



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RFC PATCH v4 2/3] vfio: platform: access device property as a list of strings Baptiste Reynal <b.reynal@virtualopensystems.com> - 2015-09-09 11:30 +0200
  Re: [RFC PATCH v4 2/3] vfio: platform: access device property as a  list of strings Alex Williamson <alex.williamson@redhat.com> - 2015-09-09 22:50 +0200

csiph-web