Re: [PATCH 2/2][RFC] kselftest: timers: Add adjtick test to validate adjtimex() tick adjustments

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	John Stultz <john.stultz@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2][RFC] kselftest: timers: Add adjtick test to validate adjtimex() tick adjustments
Date	Wed, 09 Sep 2015 19:20:02 +0200
Message-ID	<q6Rcm-150-7@gated-at.bofh.it> (permalink)
References	<q6GJX-2RB-3@gated-at.bofh.it> <q6GJX-2RB-1@gated-at.bofh.it> <q6J58-6bW-19@gated-at.bofh.it>
X-Original-To	Miroslav Lichvar <mlichvar@redhat.com>
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=pfTXvVBhbUxHvK9eeS0M2L/gHOPcxUhqt+EMBX74MTg=; b=UI7OHx1zxV9+RjZvWYPCkAvhQr3Ts1jYP9KB8+aCmHgBYWW00oMrqdJ/1NKCdsAOTe ntfqsyJg2OxSdKs/nQ5jYssagiEPwxbt6O0C5Db/bIP3OIFXI4i902wVwnkywU5UBuhA 6eqeKwOFnT3Y9HLzPVa7mAUcjSpSI7amlUQOW2fe5zTFECwZMo0lAHKTSNYb97vp1Our B56lepMp6xGgE85Y1JDYXtZNYCftDqgqHOnW7VJAGg08NXnCThoAneINWurfk7PSwA4m mbBGEsqwco9SZVG/nWZTu165jqMje2UXNmZv9jqxHEt7VFElJJKwc9Bn/a3xrraI/BmC Ri9A==
X-Gm-Message-State	ALoCoQk8RZWS7EgyGAofoSjbOtaM/frt9O2O+CYSxqlzM/Cz+65+qDe5XZKjqnQ2RMHq3BozmHOW
MIME-Version	1.0
X-Received	by 10.107.35.78 with SMTP id j75mr17314591ioj.123.1441818658510; Wed, 09 Sep 2015 10:10:58 -0700 (PDT)
Content-Type	text/plain; charset=UTF-8
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	26
Organization	linux.* mail to news gateway
X-Original-Cc	LKML <linux-kernel@vger.kernel.org>, Nuno Gonçalves <nunojpg@gmail.com>, Prarit Bhargava <prarit@redhat.com>, Richard Cochran <richardcochran@gmail.com>, Ingo Molnar <mingo@kernel.org>, Thomas Gleixner <tglx@linutronix.de>, Shuah Khan <shuahkh@osg.samsung.com>
X-Original-Date	Wed, 9 Sep 2015 10:10:58 -0700
X-Original-Message-ID	<CALAqxLWWtKbjNRSwA7UvPEe9b-KBvAQN7O+OXGX0UA1CNnRSJQ@mail.gmail.com>
X-Original-References	<1441778226-16538-1-git-send-email-john.stultz@linaro.org> <1441778226-16538-2-git-send-email-john.stultz@linaro.org> <20150909083243.GN24711@localhost>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1221574

Show key headers only | View raw

On Wed, Sep 9, 2015 at 1:32 AM, Miroslav Lichvar <mlichvar@redhat.com> wrote:
> On Tue, Sep 08, 2015 at 10:57:06PM -0700, John Stultz wrote:
>> Recently an issue was reported that was difficult to detect except
>> by tweaking the adjtimex tick value, and noticing how quickly the
>> adjustment took to be made:
>>       https://lkml.org/lkml/2015/9/1/488
>>
>> Thus this patch introduces a new test which manipulates the adjtimex
>> tick value and validates the results are what we expect.
>
> Great!
>
>> +     ppm = ((long long)tickval * MILLION)/10000 - MILLION;
>
> I think this needs to be based on sysconf(_SC_CLK_TCK) or similar,
> since the user-space HZ is not 100 on all archs.

Good point. Fixing that up now. Will resend in a bit.

thanks
-john
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 2/2][RFC] kselftest: timers: Add adjtick test to validate adjtimex() tick adjustments John Stultz <john.stultz@linaro.org> - 2015-09-09 08:10 +0200
  Re: [PATCH 2/2][RFC] kselftest: timers: Add adjtick test to validate  adjtimex() tick adjustments Miroslav Lichvar <mlichvar@redhat.com> - 2015-09-09 10:40 +0200
    Re: [PATCH 2/2][RFC] kselftest: timers: Add adjtick test to validate  adjtimex() tick adjustments John Stultz <john.stultz@linaro.org> - 2015-09-09 19:20 +0200

csiph-web