Re: [PATCH 5/6] seccomp: add a way to attach a filter via eBPF fd

From	Tycho Andersen <tycho.andersen@canonical.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 5/6] seccomp: add a way to attach a filter via eBPF fd
Date	2015-09-09 16:50 +0200
Message-ID	<q6ORc-62m-23@gated-at.bofh.it> (permalink)
References	(1 earlier) <q51IS-70a-19@gated-at.bofh.it> <q565Q-4De-9@gated-at.bofh.it> <q5fVv-1Ug-1@gated-at.bofh.it> <q6rrA-5QO-13@gated-at.bofh.it> <q6B7z-38O-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Sep 08, 2015 at 05:07:03PM -0700, Kees Cook wrote:
>
> Yeah, bpf's union looks good. Let's add a "command" flag, though:
> 
> seccomp(SECCOMP_MODE_FILTER_EBPF, int cmd, union, size);
> 
> And this cmd could be ADD_FD or something?
> 
> How's that look?

I think we can drop the size (using the same strategy as bpf() and
checking for zeroes at the end), and keep the same signature for
seccomp(); so:

seccomp(SECCOMP_MODE_FILTER_EBPF, SECCOMP_ADD_BPF_FD, &union)

Yes, I'll use this in the next version.

Tycho
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

Re: [PATCH 5/6] seccomp: add a way to attach a filter via eBPF fd Tycho Andersen <tycho.andersen@canonical.com> - 2015-09-08 15:50 +0200
  Re: [PATCH 5/6] seccomp: add a way to attach a filter via eBPF fd Kees Cook <keescook@chromium.org> - 2015-09-09 02:10 +0200
    Re: [PATCH 5/6] seccomp: add a way to attach a filter via eBPF fd Tycho Andersen <tycho.andersen@canonical.com> - 2015-09-09 16:50 +0200
      Re: [PATCH 5/6] seccomp: add a way to attach a filter via eBPF fd Alexei Starovoitov <alexei.starovoitov@gmail.com> - 2015-09-09 17:20 +0200
        Re: [PATCH 5/6] seccomp: add a way to attach a filter via eBPF fd Tycho Andersen <tycho.andersen@canonical.com> - 2015-09-09 18:00 +0200

csiph-web