Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1221453

Re: [PATCH v12 12/21] x86/xen: Add xen_cpuid() and xen_setup_gdt() to stacktool whitelists

Show all headers | View raw

On 09/09/15 14:21, Josh Poimboeuf wrote:
> stacktool reports the following false positive warnings:
> 
>   stacktool: arch/x86/xen/enlighten.o: xen_cpuid()+0x41: can't find jump dest instruction at .text+0x108
>   stacktool: arch/x86/xen/enlighten.o: xen_setup_gdt.constprop.23()+0x2e: kernel entry/exit from callable instruction
> 
> The first warning is due to xen_cpuid()'s use of XEN_EMULATE_PREFIX to
> insert some fake instructions which stacktool doesn't know how to
> decode.
> 
> The second warning is due to xen_setup_gdt()'s use of an lret
> instruction, which stacktool normally doesn't allow in callable
> functions.  But this seems to be a valid use of the instruction.
> 
> Add both functions to the stacktool whitelist.

Reviewed-by: David Vrabel <david.vrabel@citrix.com>

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v12 12/21] x86/xen: Add xen_cpuid() and xen_setup_gdt() to stacktool whitelists Josh Poimboeuf <jpoimboe@redhat.com> - 2015-09-09 15:30 +0200
  Re: [PATCH v12 12/21] x86/xen: Add xen_cpuid() and xen_setup_gdt()  to stacktool whitelists David Vrabel <david.vrabel@citrix.com> - 2015-09-09 15:40 +0200

csiph-web