Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1221275

Re: [PATCH v2 1/3] ARM: Make FORCE_MAX_ZONEORDER configurable if ARM_SINGLE_ARMV7M

Show all headers | View raw

2015-09-09 0:19 GMT+02:00 Russell King - ARM Linux <linux@arm.linux.org.uk>:
> On Tue, Sep 08, 2015 at 10:38:04PM +0200, Maxime Coquelin wrote:
>> This patch makes FORCE_MAX_ZONEORDER configurable in defconfig for ARMV7-M
>> when built for a single platform.
>
> I'd prefer if we didn't do this, because this isn't supposed to be a user
> visible "option".  It's an option that was introduced to avoid having to
> throw masses of #ifdefs into the definition of MAX_ZONEORDER.
>
> The problem with it is that it's a "well, what do I set this to?" option
> and that leads to "oh, I'll just choose the default because I don't know
> any better".
>
> Do we know why EFM32 needs a value of 9 here?  It's not documented in
> the original commit, and it really _should_ have been.
Ok, I get your point.

For STM32, the value 11 is working, but having value of 9 makes sense
in my opinion for systems with small quantity of memory (8MB in the
case of STM32F429 Discovery).
It saves some bytes in the .data section, and it might also save some
CPU cycles as there are less iterations and less split/coalescing of
pages...
Note that for CPU cycles I haven't done any measurements, this is just
my opinion after code review.

What drawbacks do you see of using a value of 9?

Thanks,
Maxime
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/3] ARMv7-M: Make FORCE_MAX_ZONE_ORDER configurable from defconfig Maxime Coquelin <mcoquelin.stm32@gmail.com> - 2015-09-08 22:40 +0200
  [PATCH v2 2/3] ARM: configs: Set FORCE_MAX_ZONE_ORDER to 9 in stm32_defconfig Maxime Coquelin <mcoquelin.stm32@gmail.com> - 2015-09-08 22:40 +0200
  [PATCH v2 3/3] ARM: configs: Set FORCE_MAX_ZONEORDER to 9 in efm32_defconfig Maxime Coquelin <mcoquelin.stm32@gmail.com> - 2015-09-08 22:40 +0200
  [PATCH v2 1/3] ARM: Make FORCE_MAX_ZONEORDER configurable if ARM_SINGLE_ARMV7M Maxime Coquelin <mcoquelin.stm32@gmail.com> - 2015-09-08 22:40 +0200
    Re: [PATCH v2 1/3] ARM: Make FORCE_MAX_ZONEORDER configurable if  ARM_SINGLE_ARMV7M Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-09-09 00:30 +0200
      Re: [PATCH v2 1/3] ARM: Make FORCE_MAX_ZONEORDER configurable if  ARM_SINGLE_ARMV7M Uwe Kleine-König   <u.kleine-koenig@pengutronix.de> - 2015-09-09 07:50 +0200
        Re: [PATCH v2 1/3] ARM: Make FORCE_MAX_ZONEORDER configurable if  ARM_SINGLE_ARMV7M Uwe Kleine-König   <u.kleine-koenig@pengutronix.de> - 2015-09-10 10:00 +0200
      Re: [PATCH v2 1/3] ARM: Make FORCE_MAX_ZONEORDER configurable if ARM_SINGLE_ARMV7M Maxime Coquelin <mcoquelin.stm32@gmail.com> - 2015-09-09 08:50 +0200

csiph-web