Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1221272

Re: [PATCH 2/3] net: irda: pxaficp_ir: convert to readl and writel

Show all headers | View raw

Petr Cvek <petr.cvek@tul.cz> writes:

> Dne 8.9.2015 v 22:24 Petr Cvek napsal(a):
>> 
>> Did you defined resources somewhere? Actual resources are in
>> "pxa_ir_resources" variable at:
I have them in patch [1], which is exactly the patch you have made yourself.

> I tried to add following patch for new resources, but now it fails with:
>
> [  141.534545] pxa2xx-ir pxa2xx-ir: can't request region for resource [mem 0x40700000-0x40700100]
> [  141.534574] pxa2xx-ir pxa2xx-ir: resource stuart not defined
> [  141.534656] pxa2xx-ir: probe of pxa2xx-ir failed with error -16
>
> That's because STUART is allocated by normal UART driver at:
>
> 	http://lxr.free-electrons.com/source/arch/arm/mach-pxa/devices.c#L244
>
> So somehow there must be configuration for STUART used with FICP and STUART
> alone (probably can be used for normal UART).
That's because you have to remove from magician.c:
	pxa_set_stuart_info(NULL);

Cheers.

--
Robert

[1]
From ea242c5b1c4dcdf2a99ea604ee542ded5e6384b9 Mon Sep 17 00:00:00 2001
From: Robert Jarzmik <robert.jarzmik@free.fr>
Date: Sat, 29 Aug 2015 00:37:51 +0200
Subject: [PATCH] ARM: pxa: add resources to pxaficp_ir

Add io memory and dma requestor lines to the irda pxa device. This is
part of the conversion of pxaficp_ir to dmaengine, and to shrink its
adherence to 'mach' includes.

Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
---
 arch/arm/mach-pxa/devices.c | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/arch/arm/mach-pxa/devices.c b/arch/arm/mach-pxa/devices.c
index e6ce669b54af..6d5ab8199536 100644
--- a/arch/arm/mach-pxa/devices.c
+++ b/arch/arm/mach-pxa/devices.c
@@ -395,6 +395,26 @@ static struct resource pxa_ir_resources[] = {
 		.end    = IRQ_ICP,
 		.flags  = IORESOURCE_IRQ,
 	},
+	[3] = {
+		.start  = 0x40800000,
+		.end	= 0x4080001b,
+		.flags  = IORESOURCE_MEM,
+	},
+	[4] = {
+		.start  = 0x40700000,
+		.end	= 0x40700023,
+		.flags  = IORESOURCE_MEM,
+	},
+	[5] = {
+		.start  = 17,
+		.end	= 17,
+		.flags  = IORESOURCE_DMA,
+	},
+	[6] = {
+		.start  = 18,
+		.end	= 18,
+		.flags  = IORESOURCE_DMA,
+	},
 };
 
 struct platform_device pxa_device_ficp = {
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 2/3] net: irda: pxaficp_ir: convert to readl and writel Petr Cvek <petr.cvek@tul.cz> - 2015-09-08 22:30 +0200
  Re: [PATCH 2/3] net: irda: pxaficp_ir: convert to readl and writel Petr Cvek <petr.cvek@tul.cz> - 2015-09-09 03:20 +0200
    Re: [PATCH 2/3] net: irda: pxaficp_ir: convert to readl and writel Robert Jarzmik <robert.jarzmik@free.fr> - 2015-09-09 08:40 +0200
      Re: [PATCH 2/3] net: irda: pxaficp_ir: convert to readl and writel Petr Cvek <petr.cvek@tul.cz> - 2015-09-10 08:20 +0200
        Re: [PATCH 2/3] net: irda: pxaficp_ir: convert to readl and writel Robert Jarzmik <robert.jarzmik@free.fr> - 2015-09-10 13:20 +0200
          Re: [PATCH 2/3] net: irda: pxaficp_ir: convert to readl and writel Petr Cvek <petr.cvek@tul.cz> - 2015-09-11 03:50 +0200
            Re: [PATCH 2/3] net: irda: pxaficp_ir: convert to readl and writel Robert Jarzmik <robert.jarzmik@free.fr> - 2015-09-11 08:30 +0200
              Re: [PATCH 2/3] net: irda: pxaficp_ir: convert to readl and writel Petr Cvek <petr.cvek@tul.cz> - 2015-09-12 06:20 +0200
                Re: [PATCH 2/3] net: irda: pxaficp_ir: convert to readl and writel Robert Jarzmik <robert.jarzmik@free.fr> - 2015-09-12 13:10 +0200
                Re: [PATCH 2/3] net: irda: pxaficp_ir: convert to readl and writel Petr Cvek <petr.cvek@tul.cz> - 2015-09-13 04:50 +0200

csiph-web