Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1221204

Re: [PATCH] power: bq24261_charger: Add support for TI BQ24261 charger

Show all headers | View raw

On Sun, Sep 6, 2015 at 2:23 PM, Ramakrishna Pallala
<ramakrishna.pallala@intel.com> wrote:

> +       chip->psy_usb = power_supply_register(&client->dev,
> +                               &bq24261_charger_desc, &charger_cfg);
> +       if (IS_ERR(chip->psy_usb)) {
> +               dev_err(&client->dev,
> +                       "power supply registration failed(%d)\n", ret);
> +               return ret;

You should not print and return ret here.

You should print and return IS_ERR(chip->psy_usb) instead.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] power: bq24261_charger: Add support for TI BQ24261 charger Fabio Estevam <festevam@gmail.com> - 2015-09-09 05:10 +0200

csiph-web