Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1221158
| Path | csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | "Rafael J. Wysocki" <rjw@rjwysocki.net> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH V2 3/9] cpufreq: ondemand: only queue canceled works from update_sampling_rate() |
| Date | Wed, 09 Sep 2015 02:40:01 +0200 |
| Message-ID | <q6BAB-3Go-7@gated-at.bofh.it> (permalink) |
| References | <pQPHz-1DB-11@gated-at.bofh.it> <q6fgK-5ca-5@gated-at.bofh.it> <q6gmu-6J6-9@gated-at.bofh.it> |
| X-Original-To | Viresh Kumar <viresh.kumar@linaro.org> |
| User-Agent | KMail/4.11.5 (Linux/4.1.0-rc5+; KDE/4.11.5; x86_64; ; ) |
| MIME-Version | 1.0 |
| Content-Transfer-Encoding | 7Bit |
| Content-Type | text/plain; charset="utf-8" |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 28 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org, preeti.lkml@gmail.com, open list <linux-kernel@vger.kernel.org> |
| X-Original-Date | Wed, 09 Sep 2015 03:06:39 +0200 |
| X-Original-Message-ID | <32794142.WpJFa6Ni1D@vostro.rjw.lan> |
| X-Original-References | <cover.1437999691.git.viresh.kumar@linaro.org> <1806697.T1XSqGqSN5@vostro.rjw.lan> <20150908015831.GY26760@linux> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1221158 |
Show key headers only | View raw
On Tuesday, September 08, 2015 07:28:31 AM Viresh Kumar wrote: > On 08-09-15, 03:11, Rafael J. Wysocki wrote: > > There really are two cases, either you pass a CPU or gov_queue_work() has to > > walk policy->cpus. > > Right (At least for now, we are doing just that.) > > > Doing it the way you did hides that IMO. > > Maybe. But I see it otherwise. Adding special meaning to a variable > (like int cpu == -1 being the special case to specify policy->cpus) > hides things morei, as we need to look at how it is decoded finally in > the routine gov_queue_work(). Oh well. I've just realized that if you combined this patch with the [6/9], you wouldn't need to make any changes to gov_queue_work() at all, because that patch removes the case in point entirely. Thanks, Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH V2 3/9] cpufreq: ondemand: only queue canceled works from update_sampling_rate() "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-09-08 02:50 +0200
Re: [PATCH V2 3/9] cpufreq: ondemand: only queue canceled works from update_sampling_rate() Viresh Kumar <viresh.kumar@linaro.org> - 2015-09-08 04:00 +0200
Re: [PATCH V2 3/9] cpufreq: ondemand: only queue canceled works from update_sampling_rate() "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-09-09 02:40 +0200
Re: [PATCH V2 3/9] cpufreq: ondemand: only queue canceled works from update_sampling_rate() Viresh Kumar <viresh.kumar@linaro.org> - 2015-09-09 04:40 +0200
Re: [PATCH V2 3/9] cpufreq: ondemand: only queue canceled works from update_sampling_rate() "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-09-09 21:50 +0200
csiph-web