Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1221145

Re: [PATCH] powerpc: define empty enable_kernel_vsx() when CONFIG_VSX=n

Show all headers | View raw

On 09/08/2015 04:47 PM, Paul Mackerras wrote:
> On Tue, Sep 08, 2015 at 12:13:11PM -0600, tim.gardner@canonical.com wrote:
>> From: Tim Gardner <tim.gardner@canonical.com>
>>
>> commit 72cd7b44bc99 ("powerpc: Uncomment and make enable_kernel_vsx()
>> routine available") neglected to define an empty inline replacement for
>> enable_kernel_vsx() when CONFIG_VSX=n.
> 
> If code that wants to call enable_kernel_vsx() is getting compiled in
> when CONFIG_VSX=n, that's a worry.  Is this patch motivated by an
> actual compile failure?  If so what was the failure?
> 
> Paul.
> 

I was having link failures after backporting 'crypto: nx' patches to a
4.2 based kernel. You may have a point in that the upstream Kconfig will
not allow those files to be compiled if CONFIG_VSX=n. I will check in my
morning if to see if I can reproduce the same link error in mainline.

rtg
-- 
Tim Gardner tim.gardner@canonical.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] powerpc: define empty enable_kernel_vsx() when CONFIG_VSX=n tim.gardner@canonical.com - 2015-09-08 20:20 +0200
  Re: [PATCH] powerpc: define empty enable_kernel_vsx() when  CONFIG_VSX=n Paul Mackerras <paulus@ozlabs.org> - 2015-09-09 00:50 +0200
    Re: [PATCH] powerpc: define empty enable_kernel_vsx() when  CONFIG_VSX=n Tim Gardner <tim.gardner@canonical.com> - 2015-09-09 01:40 +0200
      Re: [PATCH] powerpc: define empty enable_kernel_vsx() when  CONFIG_VSX=n Michael Ellerman <mpe@ellerman.id.au> - 2015-09-09 04:20 +0200
        Re: [PATCH] powerpc: define empty enable_kernel_vsx() when  CONFIG_VSX=n Tim Gardner <tim.gardner@canonical.com> - 2015-09-09 15:40 +0200
          Re: [PATCH] powerpc: define empty enable_kernel_vsx() when  CONFIG_VSX=n Michael Ellerman <mpe@ellerman.id.au> - 2015-09-10 03:00 +0200

csiph-web