Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1220352
| From | Oleg Nesterov <oleg@redhat.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [RFC PATCH 10/14] ring_buffer: Fix more races when terminating the producer in the benchmark |
| Date | 2015-09-07 20:00 +0200 |
| Message-ID | <q68RX-4gy-5@gated-at.bofh.it> (permalink) |
| References | <pRemC-3Qx-7@gated-at.bofh.it> <pRemE-3Qx-77@gated-at.bofh.it> <pTsOv-2PZ-27@gated-at.bofh.it> <q4VDs-6AD-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Sorry, I didn't read these emails, and I never looked at this code... Can't understand what are you talking about but a minor nit anyway ;) On 09/04, Petr Mladek wrote: > > + __set_current_state(TASK_RUNNING); > if (!kthread_should_stop()) > wait_to_die(); I bet this wait_to_die() can die, consumer/producer can simply exit. Just you need get_task_struct() after kthread_create(), and put_task_struct() after kthread_stop(). Oleg. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
Re: [RFC PATCH 10/14] ring_buffer: Fix more races when terminating the producer in the benchmark Petr Mladek <pmladek@suse.com> - 2015-09-04 11:40 +0200 Re: [RFC PATCH 10/14] ring_buffer: Fix more races when terminating the producer in the benchmark Oleg Nesterov <oleg@redhat.com> - 2015-09-07 20:00 +0200
csiph-web