Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1220261

similar files amd vs radeon

Path csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From Peter Senna Tschudin <peter.senna@gmail.com>
Newsgroups linux.kernel
Subject similar files amd vs radeon
Date Mon, 07 Sep 2015 17:10:02 +0200
Message-ID <q66ds-GG-3@gated-at.bofh.it> (permalink)
X-Original-To David Airlie <airlied@linux.ie>, alexander.deucher@amd.com, christian.koenig@amd.com, Jammy.Zhou@amd.com, dri-devel@lists.freedesktop.org, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=UIdPOjYav2t58SIHDHI/FFzJXsg3dUb7C8wxOkVtnI4=; b=Xy6/iGKtL1gkAFEZi58MSvlmh54qsw0i+7AEcP5XCxyghvwFlWwvl+yXDnQVCy6yLW opi4yUlBJInb3U8eRS40hybl6L/MORTDWmOGkrdbNvr2+VqrSE9eUVb9xqxk5Eh3bEs5 K96YDXycTmDI1/tEex++ATo6m8gHIBe95jTlSaetEkuhirkBJXEpRhJRRdWa5g++phFx CiGiQbc90c9oBqta1hEqBQV191sGulY33P734Neekp5jwOBrU4WbnQAfUQpVuCGt9rH1 /FFZdgo4s6cJ2nci4Z5v0KnmiKlhJ8C/zjavNyIKO8XAQuclJuLsbhJCi1Fxu16D4qZz 17yw==
MIME-Version 1.0
X-Received by 10.194.87.4 with SMTP id t4mr39470348wjz.84.1441638521815; Mon, 07 Sep 2015 08:08:41 -0700 (PDT)
Content-Type text/plain; charset=UTF-8
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 28
Organization linux.* mail to news gateway
X-Original-Date Mon, 7 Sep 2015 17:08:41 +0200
X-Original-Message-ID <CA+MoWDq=HewKYQBX_-ZYk0sQ9VU8FwQ0x3L4ZOsNjPhVx+dqDw@mail.gmail.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1220261

Show key headers only | View raw


I executed a clone detection tool* on drivers source code and I found
that there are similar files between drivers/gpu/drm/amd/ and
drivers/gpu/drm/radeon, but also inside each of theses folders.

Some examples:
drivers/gpu/drm/amd/amdgpu/dce_v11_0.c,drivers/gpu/drm/amd/amdgpu/dce_v10_0.c
drivers/gpu/drm/amd/amdgpu/ci_dpm.c,drivers/gpu/drm/radeon/ci_dpm.c
drivers/gpu/drm/radeon/kv_dpm.c,drivers/gpu/drm/amd/amdgpu/kv_dpm.c

I use meld for seeing the differences and similarities. More results
from the tool at: http://pastebin.com/iX3fhifG (The number on the
first field is the number of probable cloned lines of code).

Should these files be consolidated? And if so how?

Thank you,

Peter

* https://github.com/petersenna/ccfinderx-core

-- 
Peter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

similar files amd vs radeon Peter Senna Tschudin <peter.senna@gmail.com> - 2015-09-07 17:10 +0200

csiph-web